Skip to content

fix(aggregator): generatedAt parse + 60s future-skew gates (#1564) - #1693

Merged
dezren39 merged 2 commits into
mainfrom
queue/1830-1564-generatedat-gates
Oct 28, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/1830-1564-generatedat-gates

Conversation

@dezren39

@dezren39 dezren39 commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Implements the triage ruling on #1564 (task 1830, following the draft patch prepared by Lane D):

Laptop verification: orchestration+health suites 37/37 pass; full aggregator suite 313 pass with 1 pre-existing failure in actions.test.ts (verified identical on clean main via stash).

Closes #1564


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 28, 2026 14:41
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 853bf981-f0a9-417d-8faf-9ec127eb53e1
Commits

Reviewing files that changed from the base of the PR and between a165fc5 and ce03899.

Files selected for processing: 4
  • pm-stack/aggregator/src/feed.ts
  • pm-stack/aggregator/src/health.ts
  • pm-stack/aggregator/test/health.test.ts
  • pm-stack/aggregator/test/orchestration.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T15:08:53.097604Z ce03899 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76b03ff89e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +174 to +175
if (parsedAt - now > GENERATED_AT_FUTURE_SKEW_MS) {
return { state: "invalid", failedChecks: ["generatedAt"], generatedAt: s.generatedAt, runId: s.runId };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enforce the future-skew rejection when serving the section

For an otherwise valid section stamped more than 60 seconds ahead, this returns invalid, but normalizeOrchestrationSection() still accepts it and liveSource.orchestration() returns it with live provenance. This introduces contradictory behavior: buildAttention() marks the tier source absent/invalid while still including its published queue items, so /attention claims it is showing session-derived items only even though rejected section items remain. deriveToday() also consumes the section, and /today displays its measurements without an invalid-state warning. Make the serving path reject sections that fail this temporal gate so the new diagnosis and the displayed data remain consistent.

Useful? React with 👍 / 👎.

@dezren39
dezren39 merged commit 7248a16 into main Oct 28, 2026
4 checks passed
@dezren39
dezren39 deleted the queue/1830-1564-generatedat-gates branch October 28, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant