Repository navigation
ci: Phase 1+2 — cancel-in-progress + fast PR tier / full main tier #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # CI tier policy — fast PR tier, full main tier | ||
|
|
||
| Design: developing-today/code#1779 (ci-fast-pr-full-main). Phases: | ||
| #1780 (cancel-in-progress), #1781 (this policy), #1782 (main-breakage | ||
| chain, .github/workflows/main-broken.yml). Tracker: #1599. | ||
|
|
||
| Every workflow touched by the tier redesign carries the header | ||
| comment . Tuning the tiers | ||
| means editing THIS table by PR — never ad-hoc pipeline changes. | ||
|
|
||
| ## Change classes (§3.3 of the design) | ||
|
|
||
| | class | trigger paths (examples) | PR tier | | ||
| |---|---|---| | ||
| | 0 — prose | , docs/, comments-only changes | nothing, or markdown lint only | | ||
| | 1 — config/data | non-build, (non-workflow) | syntax parse + lint of changed files | | ||
| | 2 — package source (default) | one package's src + tests | lint/format + typecheck/syntax of affected packages + affected unit tests | | ||
| | 3 — elevated | lockfiles, / roots, /, build definitions (), , shared/core libraries | class 2 + compile check of affected packages | | ||
| | 4 — nix expressions | | class 1 + parse/eval of the changed files only (never full flake check on a PR) | | ||
|
|
||
| Default when a change spans classes: the highest class wins. The | ||
| policy ships conservative (more class 3) and loosens as the | ||
| main-breakage rate (issues labelled ) proves out. | ||
|
|
||
| ## Tier assignment in this repo (after #1781) | ||
|
|
||
| | workflow | PR tier | main tier | nightly | | ||
| |---|---|---|---| | ||
| | nix ci | treefmt/format gate only | treefmt + full flake-check | schedule in nix-ci.yml | | ||
| | id | guard + affected-crate matrix () | + full job | schedule in id-check.yml + id-e2e-nightly.yml (full flake check) | | ||
| | mcpx conformance | spec-parity leg only (measured 28s exec, run 40801660942, 2026-10-29 — under the 5m fast-leg limit) | all conformance legs + records + spec-parity | — (main covers it) | | ||
| | id bench | — (removed) | yes | — | | ||
| | go modules build / identity build / map build / mcpx nix build | class-3 paths only (see each workflow) | always (push to main, no path filter) | — | | ||
| | mcpx, lab-ops-hub, mod-tidy, research-workflow | unchanged path-gated PR checks (already PR-tier weight) | push to main | — | | ||
|
|
||
| ## Coverage rule | ||
|
|
||
| Nothing removed from PRs may vanish: the union of main-tier + | ||
| nightly jobs must cover the old PR matrix. For pkgs/id the full | ||
| flake check runs on main (id-check full-flake-check job) and | ||
| nightly twice over (id-check schedule, id-e2e-nightly). For nix ci | ||
| the flake-check job runs on main and on the nix-ci nightly | ||
| schedule. mcpx conformance legs run on every mcpx-touching merge | ||
| to main. | ||
|
|
||
| ## Dedup rule | ||
|
|
||
| A commit must not run the same suite twice via push + | ||
| pull_request. Standard shape: for PRs, | ||
| restricted to (plus tags where already | ||
| applicable, e.g. goreleaser). | ||
|
|
||
| ## Concurrency rule (#1780) | ||
|
|
||
| Standard block (design §4): group keyed by for | ||
| push-to-main, by otherwise, | ||
| — PR/branch runs cancel on supersede; main runs are never | ||
| cancelled. Exceptions: (load-bearing cip=false, #304) | ||
| and scheduled singleton/deploy workflows (cip=false) are NOT | ||
| touched. Issue-event workflows (auto-assign) use a per-issue group | ||
| so cancel-in-progress can only supersede a run for the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On
ubuntu-latestruns that need to build the heavy derivations rather than restore them from cache, this new job reintroduces a known disk-exhaustion failure. The existing equivalent job in.github/workflows/id-e2e-nightly.ymlexplicitly documents intermittentNo space left on devicefailures and reclaims roughly 20–30 GB before running the same full check (lines 52–73). This job uses the same runner but omits that preparation, so main-tier and scheduled checks can fail from runner capacity rather than code regressions. Carry over the disk-reclamation step before invoking the full check.Useful? React with 👍 / 👎.