Repository navigation
docs(mcpx): contributor test page + nested agent pointer (#1976) - #2666
Merged
Merged
Conversation
Adds the contributor test policy agents load, per #1976 approach C: - pkgs/mcpx/docs/testing.md: which tests to run by change (never the full suite locally), a failing-first test per bug, guards per bug class, the flake policy (race, shuffle, repeat, quarantine with expiry), and how to reproduce a CI failure. States the decisions and links the sibling issues (#1909, #1966, #1969, #1971, #1973) instead of restating them. - pkgs/mcpx/internal/AGENTS.md: the ~20-line version opencode attaches on read-time walk for files under internal/, pointing at the page. - pkgs/mcpx/AGENTS.md is untouched: it stays the using-mcpx user guide. Also repairs a pre-existing failure on main: TestEveryDocumentHasAChapter fails because docs/testing/inventory.md (merged in #2643) was never placed in the compendium manifest. Both new files and that one are placed now. Verified: go test ./internal/settings -count=1 (pass; was failing on clean main before this change for the inventory.md reason above). Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1976 (approach C).
What
pkgs/mcpx/docs/testing.md— the contributor test policy page: what to run by kind of change (and nevergo test ./...locally), a failing-first test per bug with permutations, guards for a bug class rather than an instance, the flake policy (-race,-shuffle=on, repeat runs, quarantine with issue + expiry, macOS gap), and how to reproduce a CI failure. It states each policy and links the issue that decides it (mcpx testing: policies for agents -- what to run, a test per bug, guards per bug class #1909, mcpx testing: which tests an agent runs, and never the full suite locally #1966, mcpx testing: a failing-first test for every bug, and a review of recent fixes #1969, mcpx testing: guard tests that close a whole bug class #1971, mcpx testing: flake policy -- race, shuffle, repeat runs, quarantine with expiry, a second OS #1973) rather than restating their reasoning.pkgs/mcpx/internal/AGENTS.md— the ~20-line version. The loading mechanism: opencode attaches the nearestAGENTS.mdup from a file being read, so this one reaches exactly agents readinginternal/source, and nobody else.pkgs/mcpx/AGENTS.mdis untouched — it stays the using-mcpx user guide.Also fixes a pre-existing red test on main
TestEveryDocumentHasAChapterfails on cleanmain:docs/testing/inventory.md(merged in #2643) was never placed indocs/compendium.manifest.json. This PR places it, and places the two new files, with the book chapter and a note each.Verification
cd pkgs/mcpx && go test ./internal/settings -count=1→ ok (before this PR it failed namingdocs/testing/inventory.md).go testinvocation (package,-run,-race,-shuffle=on,-count).Note:
pkgs/mcpxCI (mcpx.yml) is main-push-only since 814c514, so PR runs are not expected; the settings guard run above is the targeted check.Need help on this PR? Tag
@codesmith-botwith what you need.