Repository navigation
ci(mcpx): build docs in CI and deploy to GitHub Pages (#1941) - #2721
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🤖 Agent note · parked (CI pending)
|
|
Correction to the park note above: the Codex review for this PR has completed at head c8bf85d with no findings (codex-review-state: has_any_findings=false, has_unresolved_findings=false). The only remaining resume step is the pending |
|
Resumed by queue worker lane E (task 3242). The workflow as opened satisfied the triggers/permissions/deploy spec and its build was green with a clean Codex round, but the packet for #1941 also requires the base URL to be baked in as a build/derivation argument — the first pass explicitly punted that to a note on closed #1939. Added in 1adeeba: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1adeebaa36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…h (404 page assets, #1941)
Closes the implementation for #1941 (Approach C), now that its gate has landed: PR #2629 merged
.#mcpx-docsto main (#1939).What
One new file,
.github/workflows/mcpx-docs.yml:pkgs/mcpx/**,flake.nix,flake.lock, or the workflow itself: build.#mcpx-docs(Determinate nix installer + magic-nix-cache with FlakeHub off, matchingmcpx-nixbuild.yml) and upload the rendered site as themcpx-docs-siteartifact. No deploy, no PR previews.deployjob (needsbuild, main-ref only) rebuilds the same output and deploys viaactions/configure-pages+actions/upload-pages-artifact+actions/deploy-pagesin thegithub-pagesenvironment.contents: read; only the deploy job addspages: writeandid-token: write.mcpx.ymlis untouched.pages,cancel-in-progress: false.Pages enablement (done as part of this change)
GitHub Pages has been enabled on this repository with the Actions source:
Base URL
The
.#mcpx-docsoutput does not accept a base-URL/site-url argument, so — per the packet's fallback — local and CI builds are identical rather than differing only in that value. The plumbing sketch is filed back as a note on #1939. mdBook's relative links work under the/code/project path without it.Verification
CI on this PR is the verification: the new workflow's build job must build
.#mcpx-docsand upload the artifact. Post-merge, aworkflow_dispatchrun deploys and the Pages URL serves the book index (tracked on #1941).Queue task 3242 · issue #1941
Need help on this PR? Tag
@codesmith-botwith what you need.