Repository navigation
id: local-store PoC for friendly-name reference resolution (#2259) - #2756
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c51557349d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…markdown escaping, prefix provenance)
|
🤖 Agent note · parked
|
Second slice of queue task 3982 / issue #2259. The spec slice merged as #2742 (
doc/2026-10-30T13-25-00Z_design_friendly_name_references.md, resolved path repo-rootdoc/via thepkgs/id/docsymlink, stated there and in #2742). This PR is the local-store PoC the spec defines.What lands:
pkgs/id/src/references.rs— a self-contained, production-isolated PoC module over one local index (notes/documents surface):Referenceper spec §1: stable targetHash+ sigil kind + author-chosen surface + locator hints + author context, with the markdown degradation[surface](id://<hash>)and its parse round-trip.LocalIndex::resolveper spec §3: ranked candidates with provenance (store, claimauthor,claim_state) — petname tier first (@only, viewer-local), then exact alias claim, exact title, prefix, token, full-text; boosts never cross tiers.Contested;Resolution::single()refuses ties and contested tops;insert_unambiguouserrorsAmbiguous/NoMatch; the author picks a candidate explicitly viainsert, and the stored ID makes the choice permanent.renderper spec §4: all four states — Resolved, Renamed (stored surface kept, current label reported), Cleared (degrades to label + cleared marker), Unresolved for a viewer whose store lacks the target (inert text revealing only the stored surface).Tests (run in CI,
pkgs/idcargo tests): petname-outranks-claim, tier ordering, duplicate-title grouping + no auto-pick, contested-alias no silent pick, insert+render resolved + markdown round-trip, renamed-target, cleared-target, unresolved-for-another-viewer, sigil separation.Out of scope (per packet/spec): cross-store fan-out and locator fetch, hosted-store search, any change to
aliases.rsdisplay rules, any production resolution feature. The findings note goes on #2259 when this merges.Refs #2259.
Need help on this PR? Tag
@codesmith-botwith what you need.