Skip to content

id: local-store PoC for friendly-name reference resolution (#2259) - #2756

Merged
dezren39 merged 2 commits into
mainfrom
queue/3982-2259-reference-poc
Nov 2, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/3982-2259-reference-poc

Conversation

@dezren39

@dezren39 dezren39 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Second slice of queue task 3982 / issue #2259. The spec slice merged as #2742 (doc/2026-10-30T13-25-00Z_design_friendly_name_references.md, resolved path repo-root doc/ via the pkgs/id/doc symlink, stated there and in #2742). This PR is the local-store PoC the spec defines.

What lands: pkgs/id/src/references.rs — a self-contained, production-isolated PoC module over one local index (notes/documents surface):

  • Reference per spec §1: stable target Hash + sigil kind + author-chosen surface + locator hints + author context, with the markdown degradation [surface](id://<hash>) and its parse round-trip.
  • LocalIndex::resolve per spec §3: ranked candidates with provenance (store, claim author, claim_state) — petname tier first (@ only, viewer-local), then exact alias claim, exact title, prefix, token, full-text; boosts never cross tiers.
  • No silent picks: a surface claimed by ≥2 targets is Contested; Resolution::single() refuses ties and contested tops; insert_unambiguous errors Ambiguous/NoMatch; the author picks a candidate explicitly via insert, and the stored ID makes the choice permanent.
  • render per spec §4: all four states — Resolved, Renamed (stored surface kept, current label reported), Cleared (degrades to label + cleared marker), Unresolved for a viewer whose store lacks the target (inert text revealing only the stored surface).

Tests (run in CI, pkgs/id cargo tests): petname-outranks-claim, tier ordering, duplicate-title grouping + no auto-pick, contested-alias no silent pick, insert+render resolved + markdown round-trip, renamed-target, cleared-target, unresolved-for-another-viewer, sigil separation.

Out of scope (per packet/spec): cross-store fan-out and locator fetch, hosted-store search, any change to aliases.rs display rules, any production resolution feature. The findings note goes on #2259 when this merges.

Refs #2259.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 30, 2026 13:54
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef9b8fed-27b4-4c33-873c-a240ab926765
Commits

Reviewing files that changed from the base of the PR and between 58635f8 and c161f0e.

Files selected for processing: 2
  • pkgs/id/src/lib.rs
  • pkgs/id/src/references.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T14:08:53.731514Z c161f0e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c51557349d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkgs/id/src/references.rs Resolved
Comment thread pkgs/id/src/references.rs Resolved
Comment thread pkgs/id/src/references.rs Resolved
@dezren39

Copy link
Copy Markdown
Member Author

🤖 Agent note · parked

@dezren39
dezren39 merged commit 4b6d1f9 into main Nov 2, 2026
11 of 30 checks passed
@dezren39
dezren39 deleted the queue/3982-2259-reference-poc branch November 2, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant