Repository navigation
fix(muse-proxy): alias the shell tool on the direct path - #2764
Merged
Merged
Conversation
Since #2753 the muse seat has failed every real agent request with 403 client_attestation_denied: Meta's subscription-key gate rejects request bodies whose function tools carry the well-known harness shell names (shell, bash). Verified live by bisecting a captured opencode request — every other tool, the instructions, and all client headers pass; the shell tool alone trips it, and aliases (run_command, terminal) pass. The direct path now presents shell as run_command (bash as terminal) in tool definitions, history calls, and tool_choice, and translates the model's calls back in both the buffered and streaming converters. An attestation denial that still occurs (the fingerprint moved) now falls back to the CLI door instead of failing the seat. The /v1/responses passthrough still forwards verbatim and will surface the same denial to any future native-provider client; aliasing there is a follow-up if that route gains a client.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The muse seat has been hard-failing since the direct mode landed: every request carrying opencode's toolset gets a 403
client_attestation_deniedfrom Meta, and the direct path (by design) surfaces upstream answers instead of falling back.Root cause, found by capturing a real opencode request through a recording proxy and bisecting it against the live API: the gate keys on function tool names. Bodies containing a tool named
shell(orbash) are denied; everything else — the other 18 tools, the instructions, any client headers — passes.Fix, in
bin/muse-proxy.mjsonly:shellasrun_commandandbashasterminalupstream (tool definitions, historyfunction_callitems,tool_choice), and translates the model's calls back to the client names in both the buffered and the streaming response converters.Tests: two new cases in the proxy suite (alias round-trip incl. history; attestation denial falls back to exec). Suite: 22/22 pass.
Known follow-up, deliberately out of scope: the
/v1/responsespassthrough forwards bodies verbatim, so a future native-provider client would hit the same denial there.Need help on this PR? Tag
@codesmith-botwith what you need.