Repository navigation
fix(id/web): detectLanguage own-key guards — prototype names are not languages (#2787) - #2788
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2787
detectLanguage()looked up arbitrary filename extensions/stems in the plain-object mapsEXT_TO_LANG/FILENAME_TO_LANGwith truthiness checks, so inheritedObject.prototypemembers counted as hits:notes.constructorreturned theObjectconstructor function andnotes.__proto__returned a prototype object as the file's "language" (declared return typestring | undefined). TheLANG_IMPORTSlookup inensureLanguagehad the same flaw for an authored code-blocklanguageattribute —constructorwas actually called as an import function.Fix: own-key (
Object.hasOwn) guards at all threedetectLanguagelookup sites and at theLANG_IMPORTSlookup inensureLanguage. Unknown/prototype names now fall through toundefined/ "language not in registry" as intended.Verification (laptop worktree, off
main24ddc15):undefined, controls (app.ts→ typescript,Dockerfile→ dockerfile, unknown ext) unchanged. Probe:~/git/fleet/probe-2026-10-30-laneB-highlightproto/vitest run src/highlight.test.ts: 99/99 pass (2 new tests cover the prototype extension and filename paths)tsc --noEmit: cleanNeed help on this PR? Tag
@codesmith-botwith what you need.