Repository navigation
ci(mcpx): first measured iteration — static e2e shards + unit + lint + ci-ok (#1998) - #2888
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4274f76fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…retained-results fallback, run-created queue metric (#1998)
Member
Author
|
@codex review — 87adcfc fixes all 3 P2s from the previous round (ready_for_review trigger; ci-ok retained-results fallback for ci-ok-only re-run attempts; queue metrics from run created_at, labeled run-to-start). Each thread replied to and resolved. Please re-review the new head. CI disposition for run 41152763644 (head 52d9466), recorded by lane C / task 3294:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87adcfc25f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The ci-ok job's always() does not override a step's default success() condition, so the aggregation gate's exit 1 skipped the #140 measurement step on exactly the red runs whose timings the baseline needs. Step-level always() keeps the failing job conclusion and the failing gate while still printing and recording the table.
Member
Author
|
🤖 Agent note · parked (CI red — precise failing stage)
|
This was referenced Oct 31, 2026
Member
Author
|
Merge pass 2026-11-01: holding this PR. It is mergeable, but the mcpx-test workflow it introduces fails on this branch (unit FAILURE, e2e shards 0-5 FAILURE, ci-ok FAILURE; init + lint SUCCESS) — landing it would put red CI on main. Resolution task: #3813 — fix the failures on the branch, or record them as the intended #1998 baseline and adjust the ci-ok gating, then merge. |
Member
Author
|
🤖 Agent note · check-in
|
Member
Author
|
🤖 Agent note · escalated
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the first measured CI iteration for #1998 (queue task 3294), reconciled against the three live workflows rather than the deleted serial mcpx.yml.
What
.github/workflows/mcpx-test.ymlcarrying the ci-policy header, standard run_id/ref concurrency, path filters forpkgs/mcpx/**(seeds excluded), running on push to main and non-draft PRs.grep '^func Test'overinternal/e2e/*_test.go— nothing hand-maintained. Shard partition re-decided for the current suite: 345 tests in 56 files dealt round-robin (sorted names) into 6 shards: 58/58/58/57/57/57, replacing the stale 2+1 plan that would have left ~62% of e2e in one leg.go test -count=1over./...excluding/internal/e2e.gofmt -lmust print nothing +go vet ./...(the mcpx testing: first CI iteration -- unit + e2e shards + lint + nix build, and a recorded baseline #1998 leg only; the broader mcpx testing: every formatter and linter in the CI matrix, pinned by the flake (and run the plugin's bun test) #1996 lint suite already landed via mcpx: CI lint leg (vet, golangci-lint, gofmt, shellcheck, actionlint) + plugin bun test leg (#1996) #2718 and is not duplicated here).go test -runline and the surviving mcpx daemon count..github/ci-policy.md: one table row for the new workflow. The nix leg stays with mcpx-nixbuild.yml / mcpx.yml vendorHash repair — untouched.Verification
gofmt -l .in pkgs/mcpx: clean.Closes part of #1998 (baseline table follow-up stays on the issue).
Need help on this PR? Tag
@codesmith-botwith what you need.