Skip to content

fix(pm-dispatch): reset ensureWorker memo on rejection (#2902) - #2908

Merged
dezren39 merged 1 commit into
mainfrom
queue/4131-2902-ensureworker-retry
Oct 31, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4131-2902-ensureworker-retry

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Fixes #2902 (queue task 4131).

QueueClient.ensureWorker() memoised its registration promise with ??= — including when it rejected. One transient registration failure (PostgREST 5xx, network blip) wedged every later launch for the life of the process, and launchSession had already created a real session before the throw.

Change (pm-stack/dispatch/src/queue.ts): the memoised promise gets a .catch that resets workerEnsured to null before rethrowing — the reset runs before the rejection reaches any awaiting caller, and no newer attempt can have replaced the memo in between (a new attempt is only assigned while the memo is null, and this catch is the only place that nulls it). A successful registration stays cached. Worker row contents and the ignore-duplicates upsert are unchanged.

Tests (new pm-stack/dispatch/test/queue.test.ts):

  • first attempt fails (HTTP 503), second succeeds, later calls reuse the success without re-fetching
  • a fetch throw also resets the memo
  • concurrent callers share one attempt and one retry

Verified on the laptop: bun test — 42 pass / 0 fail across the dispatch suite. (bunx tsc --noEmit cannot run in this environment — @types/bun is not installed; it fails identically on clean main.)


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

ensureWorker memoised its registration promise with ??=, including when it rejected: one transient PostgREST 5xx or network blip wedged every later launch for the life of the process, each returning the same stale rejected promise -- and launchSession had already created a real session before throwing. The memo now resets on rejection (the reset runs inside the catch, before the rejection reaches any awaiting caller; a successful registration stays cached). Worker row and ignore-duplicates upsert unchanged. New test/queue.test.ts: first attempt fails (HTTP 503), second succeeds, later calls reuse the success without re-fetching; a fetch throw also resets; concurrent callers share one attempt and one retry. Verified on laptop: bun test 42 pass / 0 fail (tsc --noEmit cannot run here -- @types/bun not installed, identical failure on clean main).
@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 01:47
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c073587-337e-4907-aa5a-7c5cd0d165d9
Commits

Reviewing files that changed from the base of the PR and between 2a66b4d and 5c920e6.

Files selected for processing: 2
  • pm-stack/dispatch/src/queue.ts
  • pm-stack/dispatch/test/queue.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T01:48:58.088215Z 5c920e6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(pm-dispatch): ensureWorker caches a rejected promise forever — one transient failure wedges every later launch

1 participant