id(roc): finish the example migration — tic-tac-toe -> RocJson, roc-counter -> Screen, adopt RocText (#565) by dezren39 · Pull Request #2970 · developing-today/code

dezren39 · 2026-10-31T06:32:50Z

Finishes the example migration pinned by triage task 2164 for #565 (queue task 2637).

Changes

tic-tac-toe (pkgs/id/examples/tic-tac-toe/main.roc): records is built with pf.RocJson (RocJson.Object + the encode_or_crash idiom copied from roc-chat/lounge) instead of a hand-built JSON string. Output is byte-identical: {"board":"...","plays":N,"winner":"..."}.
roc-counter (pkgs/id/examples/roc-counter/main.roc): view/layout render through pf.Screen (boxed 20x3 "counter" screen, wider box on wide viewports — the roc-screen pattern), and update matches its event after pf.RocText.trim, so roc-counter is also the first example importing RocText.
Checked-in artifacts rebuilt with each example's build.sh: tic-tac-toe.wasm (69,319 B) and counter.wasm (59,951 B), both validated and under the 400 KB cap.
Fixture test updates (the counter wasm/source is a suite-wide fixture and its view is now a Screen frame): exact count=N view assertions in src/sandbox.rs, src/world_session/tests.rs, and src/world_compile.rs now assert the Screen frame contains count=N; the source-compile test grants the counter's new platform imports (Screen, RocText). No assertion intent changed — each still proves the count after the same inputs.

Verification (laptop, this branch)

roc check on both examples: no errors.
Both build.sh runs: built + wasm-tools validate passed.
cargo test --lib -- counter tic_tac_toe: 10 passed, 0 failed (includes the full tic-tac-toe game test, counter records/snapshot/restore tests, and both counter source-compile tests).

Note on #541

The pinned-compiler rebuild criterion completes with #541 (still open), per the task packet: these artifacts were rebuilt with the laptop's current roc via the existing sibling build.sh pattern, and the PR flags that dependency rather than blocking on it.

🤖 Agent note · pr opened

Agent: queue worker (repo-worker-code), Lane A
Session / ID: queue task 2637
Task: implement id(roc): finish the example migration: tic-tac-toe -> RocJson, roc-counter -> Screen, adopt RocText #565 example migration

^{Need help on this PR? Tag @codesmith-bot with what you need.}

…er to Screen + RocText (#565)

coderabbitai · 2026-10-31T06:32:59Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 44b1678e-9ab2-4c79-b640-d070ee130755

Commits

Reviewing files that changed from the base of the PR and between ed59bc6 and bfd5804.

Files ignored due to path filters: 2

pkgs/id/examples/roc-counter/counter.wasm is excluded by !**/*.wasm
pkgs/id/examples/tic-tac-toe/tic-tac-toe.wasm is excluded by !**/*.wasm

Files selected for processing: 7

pkgs/id/examples/roc-counter/main.roc
pkgs/id/examples/tic-tac-toe/main.roc
pkgs/id/src/sandbox.rs
pkgs/id/src/world_compile.rs
pkgs/id/src/world_net.rs
pkgs/id/src/world_session/tests.rs
pkgs/id/src/world_store.rs

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

chatgpt-codex-connector · 2026-10-31T06:33:05Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-31T08:16:25.955328Z	`bfd5804`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 720eb57701

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… + grant Screen/RocText in native compile test (#565, Codex P2 x2 on PR #2970)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfd580419b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-31T08:16:23Z

+import pf.Screen
+import pf.RocText


Grant the new imports in source-compilation integration tests

When Roc and the platform assets are available, test_worlds_compile_roc_sources_on_the_fly and test_worlds_compile_native_workers_on_the_fly in tests/cli_integration.rs now fail before compilation. Both load this source but start fresh servers without capability grants; WorldCore::new initializes an empty grant set, and WorldService::compile_and_install passes its effective grants to check_imports, which rejects Screen. Grant Screen and RocText in these fixtures before compiling; updating the direct compilation unit tests does not cover these service-level consumers.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-31T08:16:23Z

+    base = Screen.boxed(Screen.new(w, h), 0, 0, w, h, "counter")
+    Screen.render_json(Screen.put_text(base, 2, 1, "count=${model.count.to_str()}", { fg: 0, bg: 0, bold: Bool.False }))


Rebaseline the counter's rendering fuel budgets

The sandbox-enabled suite still enforces 100,000-fuel budgets for both counter View and Layout in src/sandbox.rs::FUEL_BUDGETS, despite replacing the inexpensive text output with Screen construction and JSON rendering. The equivalent existing roc-screen renderer has recorded baselines of 123,675 fuel for its 20×3 view and 378,384 for its wide layout, already above those counter limits. Consequently checked_in_examples_stay_within_fuel_budgets retains obsolete thresholds for the rebuilt artifact. Measure the new counter and deliberately update its rendering budgets alongside this change.

Useful? React with 👍 / 👎.

id(roc): finish example migration — tic-tac-toe to RocJson, roc-count…

720eb57

…er to Screen + RocText (#565)

dezren39 requested a review from a team as a code owner October 31, 2026 06:32

chatgpt-codex-connector Bot reviewed Oct 31, 2026

View reviewed changes

Comment thread pkgs/id/examples/roc-counter/main.roc Resolved

Comment thread pkgs/id/examples/roc-counter/main.roc Resolved

dezren39 mentioned this pull request Oct 31, 2026

id(roc): finish the example migration: tic-tac-toe -> RocJson, roc-counter -> Screen, adopt RocText #565

Closed

4 tasks

dezren39 added 2 commits October 31, 2026 03:09

id(roc): migrate remaining counter-fixture assertions to Screen views…

e29ddd5

… + grant Screen/RocText in native compile test (#565, Codex P2 x2 on PR #2970)

style(id): rustfmt the counter-fixture assertion updates (#565)

bfd5804

dezren39 merged commit c1b9052 into main Oct 31, 2026
1 check passed

dezren39 deleted the queue/2637-565-roc-example-migration branch October 31, 2026 08:15

chatgpt-codex-connector Bot reviewed Oct 31, 2026

View reviewed changes

Navigation Menu

Repository navigation

id(roc): finish the example migration — tic-tac-toe -> RocJson, roc-counter -> Screen, adopt RocText (#565) - #2970

id(roc): finish the example migration — tic-tac-toe -> RocJson, roc-counter -> Screen, adopt RocText (#565)#2970
dezren39 merged 3 commits into
mainfrom
queue/2637-565-roc-example-migration

dezren39 commented Oct 31, 2026 •

edited by blacksmith-sh Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 31, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 31, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 31, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		base = Screen.boxed(Screen.new(w, h), 0, 0, w, h, "counter")
		Screen.render_json(Screen.put_text(base, 2, 1, "count=${model.count.to_str()}", { fg: 0, bg: 0, bold: Bool.False }))

		import pf.Screen
		import pf.RocText

Conversation

dezren39 commented Oct 31, 2026 • edited by blacksmith-sh Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Verification (laptop, this branch)

Note on #541

Uh oh!

coderabbitai Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dezren39 commented Oct 31, 2026 •

edited by blacksmith-sh Bot

Loading

coderabbitai Bot commented Oct 31, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 31, 2026 •

edited

Loading