[dezren39]

What

Adds a darwin/arm64 cross-compile gate for mcpx test packages (#1988 follow-up from triage task 2893):

• pkgs/mcpx/scripts/darwin-compile-check.sh — GOOS=darwin GOARCH=arm64 go build ./... plus go test -c -o /dev/null for every package with test files. Fails, naming each package, when a test package does not compile for darwin; no silent skips, no || true.
• Single exception list: the script's DARWIN_COMPILE_EXCEPTIONS variable holds exactly one entry today — internal/daemon → mcpx: takeover/upgrade/handoff unsupported on darwin; Linux-only tests break the darwin build #237 (takeover_test.go:24: undefined: syscall.SOCK_CLOEXEC), with a comment saying to delete it when mcpx: takeover/upgrade/handoff unsupported on darwin; Linux-only tests break the darwin build #237's compile fix lands. Emptying the list is a one-line change.
• CI wiring: a Darwin compile gate step in the mcpx workflow's test (push) and stress-pr (PR) jobs — existing ubuntu runners, no new runner, no macOS matrix (that's mcpx testing: flake policy -- race, shuffle, repeat runs, quarantine with expiry, a second OS #1973/mcpx testing: environments -- nix flake, container, local, remote -- as CI matrix entries #1983).
• Docs: the local command and the exception rule are documented in pkgs/mcpx/AGENTS.md.

Out of scope (per the task packet): fixing SOCK_CLOEXEC (#237), adding a macOS runner (#1973/#1983), running the suite on darwin (#1988 stays open for the real Mac run).

Verification (laptop, at main c1b9052)

• Baseline re-verified fresh: darwin go build ./... passes; exactly one test package fails to compile — internal/daemon, same error as the packet recorded at 4d15775.
• Gate with exception list: passes in ~38s (33s scan), reporting the one known exception.
• Gate with DARWIN_COMPILE_EXCEPTIONS="": fails (exit 1), naming internal/daemon — proves it detects the class.
• Workflow YAML parses; script is shellcheck-clean at warning severity.

Refs #1988, #237. Queue task 3285.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: d86c6b78-a8c3-4d34-a6cd-cc0fd431dc6a

Commits

Reviewing files that changed from the base of the PR and between c1b9052 and 5b5c2b5.

Files selected for processing: 3

• .github/workflows/mcpx.yml
• pkgs/mcpx/AGENTS.md
• pkgs/mcpx/scripts/darwin-compile-check.sh

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-31T08:35:17.077832Z	5b5c2b5	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[dezren39]

🤖 Agent note · parked

• Agent: queue worker (repo-worker-code), lane E shift
• Session / ID: queue task 3285
• Found via: queue claim (resume)
• Task: mcpx darwin compile gate (mcpx: Go tests fail on macOS (2 path tests in internal/config, plus 2 unidentified packages) #1988) — PR mcpx: darwin/arm64 test-compile gate (#1988) #2995 @ 5b5c2b5. Fresh revalidation this shift: Codex summary for the head confirms no findings (has_any_findings=false, has_unresolved_findings=false); PR still OPEN.
• State: CI run 41185095612 still queued across the board (lint, plugin tests, stress PR-changed, nix docs build — fleet runner backlog, ~1h now). Nothing is failing; there is simply nothing to merge against yet. Parked 20 min per the CI rule.
• Resume: checks green on 5b5c2b5 → merge PR 2995 → complete fixed_merged (mcpx: Go tests fail on macOS (2 path tests in internal/config, plus 2 unidentified packages) #1988 stays open for the real Mac run, per the task packet).
• Links: PR mcpx: darwin/arm64 test-compile gate (#1988) #2995 · issue mcpx: Go tests fail on macOS (2 path tests in internal/config, plus 2 unidentified packages) #1988