Repository navigation
fix(mcpx/config): refuse unclosed/empty regexp tool patterns; escape leading ^ in glob classes - #3038
Merged
Merged
Conversation
…ape leading ^ in glob classes (#1631) CompileToolPatterns silently mistranslated three entry shapes: an unclosed /regexp fell through to a never-matching exact name, // compiled the empty regexp and matched everything, and a glob class body beginning with ^ was copied verbatim into the RE2 class, inverting it. Now: any entry beginning with / that is not a complete /.../ pair (including the lone /) is a compile error naming the entry, // is refused as an empty regexp, and a body-leading ^ is escaped when the class is not the [!...] negation form. Regression tests cover all three shapes plus controls (well-formed /delete/, /( /, delete_[, empty entry, [!d] negation). go test ./internal/config/ passes on the laptop.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1631. Queue task 4067 (repo-health-code-pilot).
What
CompileToolPatternssilently mistranslated three entry shapes:/delete, or the lone/) fell through to an exact name that matches nothing a server offers — a deny entry that silently protects nothing;//compiled the empty RE2 regexp, which matches every name;^([^d]elete_*) copied the^verbatim into the RE2 class, inverting it (matchedxelete_x, notdelete_x).Change (
pkgs/mcpx/internal/config/toolpattern.go)/must now be a complete/.../pair: unclosed entries are a compile error naming the entry, and//is refused as an empty regexp. Well-formed regexp entries are unchanged (still unanchored RE2).globRegexpescapes a body-leading^when the class is not the[!...]negation form, preserving the glob meaning (literal^member).[!...]is unchanged: there the body-leading^is a member of the negated set, which RE2 already reads correctly.Tests
New regression tests in
toolpattern_test.gocover all three shapes plus controls (/delete/unanchored,/(/,delete_[, empty entry,[!d]negation).go test ./internal/config/passes on the laptop; CI (mcpx workflow) is the remaining gate.Need help on this PR? Tag
@codesmith-botwith what you need.