Skip to content

fix(projector): parseLimit honours only decimal-digit spellings (#2971) - #3077

Merged
dezren39 merged 1 commit into
mainfrom
queue/4275-2971-projector-parselimit
Oct 31, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4275-2971-projector-parselimit

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Fixes #2971 (the #1547 residual), per the pinned fix in triage task 4269 / queue task 4275.

parseLimit in pm-stack/projector/src/server.ts parsed the limit query parameter with Number(raw) + Number.isInteger, so every spelling Number() accepts was honoured instead of falling back to the endpoint default: 1e2 → 100, 0x10 → 16, 5.0 → 5, +5 → 5, 5 → 5.

Change

  • parseLimit now honours only /^[0-9]+$/ spellings: parse the digits, require ≥ 1, clamp to the endpoint max as before. Absent parameter still defaults; every other spelling (exponent, hex, decimal point, sign, surrounding whitespace, empty) falls back to the endpoint default. No change to endpoints, defaults, or the store layer.
  • test/limit.test.ts: coercible-spelling matrix for both endpoints (items default 200/max 1000, comments default 500/max 1000) — 1e2, 0x10, 5.0, +5, 5, 5 fall back; 5 honoured; 99999 clamps — plus the coercible spellings added to the /items endpoint invalid-limit loop.

Verification


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 13:53
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd47aa99-fa02-487b-81d0-226f95993036
Commits

Reviewing files that changed from the base of the PR and between d4279a4 and 132543d.

Files selected for processing: 2
  • pm-stack/projector/src/server.ts
  • pm-stack/projector/test/limit.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T15:29:14.344911Z 132543d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

Copy link
Copy Markdown
Member Author

@codex review

Lane E verification note: diff is exactly the pinned #2971 fix (regex gate in parseLimit + coercible-spelling matrix for both endpoints). No CI check runs exist for pm-stack paths on this PR (only CodeRabbit, neutral) — verified fresh via the check-runs API. Laptop verification on head 132543d: bun test test/limit.test.ts 13 pass / 0 fail. Requesting Codex review before merge per the fleet Codex gate.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 132543d4ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dezren39
dezren39 merged commit 7946d8f into main Oct 31, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4275-2971-projector-parselimit branch October 31, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant