Repository navigation
fix(projector): parseLimit honours only decimal-digit spellings (#2971) - #3077
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Lane E verification note: diff is exactly the pinned #2971 fix (regex gate in parseLimit + coercible-spelling matrix for both endpoints). No CI check runs exist for pm-stack paths on this PR (only CodeRabbit, neutral) — verified fresh via the check-runs API. Laptop verification on head 132543d: bun test test/limit.test.ts 13 pass / 0 fail. Requesting Codex review before merge per the fleet Codex gate. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #2971 (the #1547 residual), per the pinned fix in triage task 4269 / queue task 4275.
parseLimitinpm-stack/projector/src/server.tsparsed thelimitquery parameter withNumber(raw)+Number.isInteger, so every spellingNumber()accepts was honoured instead of falling back to the endpoint default:1e2→ 100,0x10→ 16,5.0→ 5,+5→ 5,5→ 5.Change
parseLimitnow honours only/^[0-9]+$/spellings: parse the digits, require ≥ 1, clamp to the endpoint max as before. Absent parameter still defaults; every other spelling (exponent, hex, decimal point, sign, surrounding whitespace, empty) falls back to the endpoint default. No change to endpoints, defaults, or the store layer.test/limit.test.ts: coercible-spelling matrix for both endpoints (items default 200/max 1000, comments default 500/max 1000) —1e2,0x10,5.0,+5,5,5fall back;5honoured;99999clamps — plus the coercible spellings added to the/itemsendpoint invalid-limit loop.Verification
bun test test/limit.test.ts— 13 pass, 0 fail (77 expect() calls); existing projector: read-API limit is never validated — ?limit=-1 returns the whole table and ?limit=2.7 500s the request #1547 tests pass unchanged.Need help on this PR? Tag
@codesmith-botwith what you need.