Skip to content

fix(projector): scope comment identity by kind - #3132

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/4413-2694-comment-identity
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/4413-2694-comment-identity

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

- comment identity: id
+ comment identity: (id, kind)
+ scope webhook deletions to their kind
+ reject legacy schema before startup

Closes #2694. Reconciliation retains raw IDs and uses its existing stream-specific kind.

Evidence

  • Before: new store regressions failed: colliding IDs overwrote each other and legacy schema did not report the required rebuild.
  • After: cd pm-stack/projector && bun test — 48 passed; includes real signed webhook collisions and both deletion kinds.

Merge Danger

Door: one-way for a rebuild without a backup.

Blast Radius: projector.

Existing databases fail clearly until upgraded. Stop writers and back up the entire database, especially pmp_links; do not delete the shared database. Drop only pmp_v_subject_activity and pmp_comments, start the upgraded projector to recreate them, then reconcile every configured repo and check all stream errors. Deleted comments and overwritten historical records absent from GitHub cannot be reconstructed; retain the backup. See the projector README for SQL and details.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 16:09
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6fb41ab8-cd4f-465b-a8bf-15c2aa5aa5df
Commits

Reviewing files that changed from the base of the PR and between b878339 and 4422a79.

Files selected for processing: 8
  • pm-stack/projector/README.md
  • pm-stack/projector/schema.sql
  • pm-stack/projector/src/projector.ts
  • pm-stack/projector/src/server.ts
  • pm-stack/projector/src/store.ts
  • pm-stack/projector/test/e2e.test.ts
  • pm-stack/projector/test/projector.test.ts
  • pm-stack/projector/test/store.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T16:18:39.827672Z 4422a79 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant