Skip to content

fix(aggregator): match charges to quota providers - #3168

Merged
dezren39 merged 3 commits into
mainfrom
queue/4573-3119-quota-charge-catalog
Oct 31, 2026
Merged

dezren39 merged 3 commits into
mainfrom
queue/4573-3119-quota-charge-catalog

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

 matchCharges(candidates, catalog)
-  catalog = SaaS services
+  catalog = SaaS services + quota providers and merchant aliases

Closes #3119.

Evidence

  • Before: task 4539 reproduced ANTHROPIC and OPENAI as unmatched using the SaaS-only catalog.
  • After: bun test test/charges-catalog.test.ts test/charges-match.test.ts — 12 tests pass, covering providers, aliases, SaaS and an unknown merchant.

Merge Danger

Door: two-way

Blast Radius: charge classification


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 17:47
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8a4831f6-b7d5-494a-a356-9ece43675d99
Commits

Reviewing files that changed from the base of the PR and between 5cc6bad and de28eef.

Files selected for processing: 5
  • pm-stack/aggregator/scripts/collect-fleet-feed.ts
  • pm-stack/aggregator/src/charges-catalog.ts
  • pm-stack/aggregator/src/charges-collect.ts
  • pm-stack/aggregator/test/charges-catalog.test.ts
  • pm-stack/aggregator/test/charges-collect.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T18:44:04.165897Z de28eef New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1e756a119

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…els (#3119)

sameCharge now expands each label through its provider alias group (PROVIDER_ALIASES exported from charges-catalog), so a canonicalized auto row (Meta Model API) still dedupes the merchant-spelled hand-fed row (Meta PAYG spill, around the METAPAY alias). Codex review finding on PR #3168.
@dezren39

Copy link
Copy Markdown
Member Author

@codex review

a002a3e fixes the dedupe finding on its thread (alias-group expansion in sameCharge, with regressions). Please re-review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: a002a3e1ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dezren39
dezren39 merged commit 661c779 into main Oct 31, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4573-3119-quota-charge-catalog branch October 31, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(aggregator): charge-matching catalog omits the AI quota providers, so Anthropic/OpenAI charges always surface as unrecognized (PR #2149)

1 participant