[dezren39]

Fixes #3124.

liveSource.usage() consumed the fleet feed's charge evidence (feed.charges) and the unmatched-charge attention flags (feed.chargesAttention) only inside the if (feed?.saas && feed.saas.length) gate. A feed carrying valid charges but no saas section — or the quota-view fallback path, or the fixtures fallback — silently dropped every auto-matched charge.

Per the pinned form from triage task 4544:

• Compute feedCharges + feedChargeFlags once, before the branch.
• Feed-saas path: unchanged behaviour, now using the hoisted values.
• Quota-view fallback: feed charges merge ahead of prose-extracted charges (deduped on the full row identity) and the unmatched-charge flags are appended to attention.
• Fixtures fallback: keeps the feed charges + flags when a feed exists (and clears the empty-charges note); fixtures only stand in for sections that never arrived.
• Services/payg/subscriptions fallback behaviour untouched.

Tests (laptop, bun test in pm-stack/aggregator):

• New test/charges-feed-gate.test.ts: 3 pass — quota-view fallback and fixtures fallback now surface a no-saas feed's charges + flags; saas path unchanged. The two fallback tests fail on the pre-fix code (verified by stashing the fix), the saas-path test passes both ways.
• Full aggregator suite: 710 pass / 7 fail — the 7 failures are pre-existing PAGES-manifest assertions (impl(aggregator): make / the stack front door - overview of all projects, attention, health, quotas (board moves to /board) #1134/fix(aggregator): navigation coherence - 10-item nav overflows on mobile, sub-pages undiscoverable #1135, aa-explorer, attention action controls) reproduced on pristine main; this diff touches none of those paths.

Queue task 4590 (lane C). Sibling fix #3122 (task 4542) touches the charges producer's surfaced-keys persistence, not this consumer.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1a854258-e07c-4a8f-8309-36e02a0fbe50

Commits

Reviewing files that changed from the base of the PR and between 4bab46e and 4ea1b99.

Files selected for processing: 2

• pm-stack/aggregator/src/sources/live.ts
• pm-stack/aggregator/test/charges-feed-gate.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-31T17:55:29.922064Z	4ea1b99	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8815eb87d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Reuse charge-level deduplication for the fallback merge

When a feed without SaaS data contains an auto-collected charge also recorded in the local quota view, full-row equality fails to recognize the duplicate: feed rows use sources such as Plaid or Gmail alert, whereas extractCharges() uses descriptive evidence strings and may have different labels or dates. This merge therefore displays the same charge twice and inflates the total calculated in render.ts's chargesStripHtml(). The existing mergeChargeRows() in charges-collect.ts already handles these differences and gives automatic evidence precedence; reuse that charge-level merge instead of reintroducing duplicate prose evidence.

Useful? React with 👍 / 👎.

[dezren39]

Fixed in 4ea1b99 — correct catch. The fallback merge now reuses mergeChargeRows(feedCharges, extractCharges(...)) from charges-collect.ts: charge-level matching (amount + 3-day window + normalized merchant containment) with the automatic feed evidence taking precedence, instead of my full-row-identity dedupe. Added a regression test where the same charge exists in both the feed (source plaid, dated 2026-10-27) and the quota-view prose (extractor row dated 2026-10-25 with a descriptive source string): usage() returns exactly one row, the feed's. Targeted suites pass (charges-feed-gate, charges-collect, usage, supabase-export: 54/54).

[dezren39]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 4ea1b996ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".