Skip to content

fix(pkarr): bootstrap a brand-new Worker via cf deploy (#1829) - #3241

Merged
dezren39 merged 1 commit into
mainfrom
pkarr-deploy-bootstrap
Oct 31, 2026
Merged

dezren39 merged 1 commit into
mainfrom
pkarr-deploy-bootstrap

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Found by the first real deploy run: cf workers versions create cannot create a brand-new Worker — it refuses and says to run the deploy command first. deploy.mjs now checks cf workers get pkarr: when the Worker doesn't exist, the first deploy bootstraps via cf deploy --tag git-<sha12> --message ... (creates version 1 + its deployment together, same stamps); every later deploy uses the versions flow. Still cf-only — no wrangler fallback needed. Gap recorded in the package README and the deployment-standard design doc.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

cf workers versions create refuses to create a new Worker ('run
the deploy command first') — found by the first real deploy run.
deploy.mjs now checks whether the Worker exists: if not, the first
deploy goes through cf deploy with the same git-SHA tag/message
(creating version 1 and its deployment together); every later
deploy uses the versions flow. Gap recorded in the README and the
deployment-standard design doc.
@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 23:21
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-31T23:21:49.469083Z
We couldn’t complete this review. Comment @codex review to try again.
0a1295e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 55b2b00e-93c3-4d7c-988c-e227eb0ab316
Commits

Reviewing files that changed from the base of the PR and between 8e4ef90 and 0a1295e.

Files selected for processing: 3
  • doc/2026-10-31T23-00-00Z_design_cloudflare_worker_deployment_standard.md
  • pkgs/pkarr-worker/README.md
  • pkgs/pkarr-worker/deploy.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@dezren39
dezren39 merged commit fdd8811 into main Oct 31, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant