Skip to content

fix(pkarr): pass --strategy percentage to deployments create (#1829) - #3244

Merged
dezren39 merged 1 commit into
mainfrom
pkarr-deploy-strategy
Oct 31, 2026
Merged

fix(pkarr): pass --strategy percentage to deployments create (#1829)#3244
dezren39 merged 1 commit into
mainfrom
pkarr-deploy-strategy

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Member

Found by the first versions-flow deploy run: upload + ?deployable=true pre-check passed, then cf workers deployments create refused — --strategy is required (one of: percentage) in non-interactive mode. createDeployment now passes --strategy percentage.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Muse Sweep
fix(pkarr): pass --strategy percentage to deployments create (#1829)
6c71c3b 
cf requires the strategy flag explicitly in non-interactive runs;
found by the first versions-flow deploy (the upload and deployable
pre-check passed, the deployment create refused).
@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 23:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-31T23:24:12.076063Z
We couldn’t complete this review. Comment @codex review to try again.		 6c71c3b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c2ce3ae3-2510-43dc-a0d0-eb6ddab9b5a8
Commits

Reviewing files that changed from the base of the PR and between 297a3ac and 6c71c3b.

Files selected for processing: 1
  • pkgs/pkarr-worker/deploy.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@dezren39
dezren39 merged commit 5e08e19 into main Oct 31, 2026
1 check passed
@dezren39
dezren39 deleted the pkarr-deploy-strategy branch October 31, 2026 23:24
This was referenced Oct 31, 2026
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dezren39