Repository navigation
Conversation
Removes a global \`decorationGeneration\` counter that was forcing ProseMirror to recreate cursor and selection DOM nodes on every single transaction. Instead, widget keys are now derived from their underlying dynamic data properties (opacity, color, connection state), allowing ProseMirror to efficiently recycle DOM nodes and avoid layout thrashing. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
Closing as obsolete: key-only change leaves collab-cursor-hovered orphaned after unhover; superseded by #379 |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What: Removes global
decorationGenerationcounter and uses stable, state-derived keys for ProseMirror cursor and selection widgets.🎯 Why: The global counter was bypassing ProseMirror's built-in DOM node recycling, forcing continuous recreation of widgets on every transaction and causing layout thrashing.
📊 Impact: Significantly reduces DOM manipulation and layout thrashing during active editing and cursor movement.
🔬 Measurement: Verify by typing or moving cursors while profiling the renderer - DOM node creation/destruction for cursors will drop to near zero unless their visual state changes.
PR created automatically by Jules for task 17317210007050591248 started by @dezren39
Need help on this PR? Tag
@codesmith-botwith what you need.