Skip to content

⚡ Bolt: Optimize ProseMirror decoration recycling - #327

Closed
dezren39 wants to merge 1 commit into
mainfrom
bolt-cursor-perf-17317210007050591248
Closed

dezren39 wants to merge 1 commit into
mainfrom
bolt-cursor-perf-17317210007050591248

Conversation

@dezren39

@dezren39 dezren39 commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

💡 What: Removes global decorationGeneration counter and uses stable, state-derived keys for ProseMirror cursor and selection widgets.
🎯 Why: The global counter was bypassing ProseMirror's built-in DOM node recycling, forcing continuous recreation of widgets on every transaction and causing layout thrashing.
📊 Impact: Significantly reduces DOM manipulation and layout thrashing during active editing and cursor movement.
🔬 Measurement: Verify by typing or moving cursors while profiling the renderer - DOM node creation/destruction for cursors will drop to near zero unless their visual state changes.


PR created automatically by Jules for task 17317210007050591248 started by @dezren39


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Removes a global \`decorationGeneration\` counter that was forcing ProseMirror to recreate cursor and selection DOM nodes on every single transaction. Instead, widget keys are now derived from their underlying dynamic data properties (opacity, color, connection state), allowing ProseMirror to efficiently recycle DOM nodes and avoid layout thrashing.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@dezren39

Copy link
Copy Markdown
Member Author

Closing as obsolete: key-only change leaves collab-cursor-hovered orphaned after unhover; superseded by #379

@dezren39 dezren39 closed this Oct 24, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as obsolete: key-only change leaves collab-cursor-hovered orphaned after unhover; superseded by #379

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant