Repository navigation
id(world-manifest): document module_hash as plain hex, not blake3:<hex> - #3412
Merged
Merged
Conversation
The rustdoc claimed the form blake3:<hex>, which validate can never accept (71 chars > 64 max, colon is not a hex digit), while the producer, stored state, fixtures and plan() comparisons are all plain hex. Correct the rustdoc to the plain-hex canonical form (1 to 64 hex digits, no prefix) and add a regression test: a full 64-hex module_hash parses; blake3:-prefixed values (short and full-length) are rejected. Fixes #2166
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2166.
The
WorldManifest::module_hashrustdoc claimed the formblake3:<hex>, whichvalidatecan never accept (71 chars >MAX_NAME_BYTES=64, and:is not a hex digit), while the live producer (world_session::module_hash()= iroh-blobsHash::to_string()), stored state, fixtures, andplan()'s verbatim string comparisons are all plain hex. A world.toml written per the docs failed to parse.Per the triage pin on #2166 (task 3206, canonical form = plain hex; accept/strip-prefix rejected):
blake3:prefix. No other manifest doc inpkgs/idnames ablake3:<hex>module_hash form (remainingblake3:hits are crate paths / field names, not manifest docs).module_hash_uses_plain_hex_without_a_blake3_prefix: a full 64-hex module_hash parses;blake3:abc123and a 71-charblake3:<64 hex>value are rejected.validate's rule, error message, the producer, and plan/apply semantics are unchanged.Tests (laptop):
cargo test --lib world_manifestin pkgs/id — 18 passed, 0 failed, including the new regression test; fullcargo test world_manifestrun exit 0.Queue task 5197 (repo-health-code-pilot).
Need help on this PR? Tag
@codesmith-botwith what you need.