Repository navigation
fix(aggregator): skip invalid Gmail receipt dates without dropping the batch (#2448) - #3439
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2448. Queue task 5335 (follow-up of triage task 3663).
What
In
scripts/produce-charge-candidates.ts, the Gmail per-message day was derived as(m.message_sent_at?.user_local ?? "").slice(0, 10) || isoDay(new Date(m.date ?? ""))before the format/skip check — so a message with no local day and a missing/garbleddatemadeisoDaythrowRangeErroron an invalid Date. The throw escapedgmailCandidates, andmain()'s catch discarded the whole Gmail batch (Plaid candidates only) for one bad message.The derivation now goes through an exported pure helper,
gmailMessageDay: the triage local day when present, else the parsed message date, else""for a missing/garbled date — the existing format check then counts that message as skipped and the loop continues with the rest of the batch. No behavior change for well-formed messages; CLI--start/--endvalidation is #3333 and untouched, as are Plaid parsing, amount/merchant extraction, and charge matching.Tests (laptop, Bun)
gmailMessageDay (#2448)describe intest/produce-charge-candidates.test.ts: local day wins; parseable date used; missing date →""(no throw); garbled/empty date →""; a bad message in a batch does not stop later messages resolving.bun test test/produce-charge-candidates.test.ts— 20/20 pass (15 pre-existing + 5 new).bun run typecheck— 6 errors, the identical pre-existing set on clean main (verified by stash comparison); none in the touched files.Need help on this PR? Tag
@codesmith-botwith what you need.