Skip to content

fix(catalog-sync): validate proxy model response shapes (#2827) - #3487

Merged
dezren39 merged 2 commits into
mainfrom
queue/5433-2827-catalogsync-shape
Nov 3, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/5433-2827-catalogsync-shape

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

enumerateProxy
  parse snapshot or live /v1/models response
  validate body + data array + each non-empty string id
  on invalid shape: throw into existing per-provider not-enumerable path

Closes #2827.

Evidence

  • Before: missing data became []; an id-less entry could flow into additions_validated and crash --apply.
  • After: node --test bin/provider-catalog-sync.test.mjs — 21 passed, 0 failed. Covers missing/non-array data, id-less and null entries, plus a valid snapshot control.

Merge Danger

Door: Two-way

Blast Radius: Low — only malformed proxy/snapshot response shapes change; valid enumerations preserve the same ids and report.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 10:17
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5db785a-9768-48fc-878e-d91f2f5f4b5e
Commits

Reviewing files that changed from the base of the PR and between 5bc74ff and 275d47d.

Files selected for processing: 2
  • bin/provider-catalog-sync.mjs
  • bin/provider-catalog-sync.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T13:49:22.582374Z
We couldn’t complete this review. Comment @codex review to try again.
275d47d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@dezren39
dezren39 merged commit f04a439 into main Nov 3, 2026
1 check passed
@dezren39
dezren39 deleted the queue/5433-2827-catalogsync-shape branch November 3, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant