[dezren39]

Fixes #2664 (Phase 1, per the adopted decision on the issue; fix task 5418).

• resolveSessionDirectory now applies ONE rule to both caller types (OIDC and bearer): missing/empty/whitespace directory → the target repo's REPO_DIRS clone; an explicit directory must be an absolute, lexically normalized path equal to or inside that clone. Relative paths, other repos' clones, prefix-sibling paths, and arbitrary absolute paths are rejected with ValidationError (→ 400) before any issue/task/session side effect (the check already runs first in handleSessions).
• parseSessionRequest: empty/whitespace title and directory parse as omitted — a blank title now falls back to titleFromPrompt (previously "" defeated the ?? fallback in server.ts) and a blank directory to the repo default.
• Supersedes the fix(pm-dispatch): POST /v1/sessions accepts an arbitrary directory — OIDC callers escape their repo clone #2903-era bearer free-form directory; the two README passages and the validate.ts doc comment are updated to match. Extra roots/allowlists remain out of scope per design design(pm-dispatch): launch pipeline, staged — validate the whole request at the boundary, one commit point, nothing after it can fail the launch #2668.

Tests (laptop, bun test):

• test/validate.test.ts: 33/33 pass — new coverage for blank/default, exact root, valid subdirectory, normalization (./, ../, trailing slashes), relative/foreign/arbitrary/prefix-sibling rejection, both caller types, plus blank title/directory parsing.
• Full dispatch suite: 85 pass; the two server.test.ts "passes validation" tests race their 5s timeout on this machine (4793–5015ms across runs) — the identical timeout occurs on unmodified main, so it is a pre-existing borderline flake under load, not a regression: the foreign-directory rejection passes fast and both slow tests reach the post-validation path.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T10:41:26.803241Z	2acd446	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b6813fdd-8f16-4008-9d32-2ca7ed129057

Commits

Reviewing files that changed from the base of the PR and between 9f48e29 and 2acd446.

Files selected for processing: 3

• pm-stack/dispatch/README.md
• pm-stack/dispatch/src/validate.ts
• pm-stack/dispatch/test/validate.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[dezren39]

🤖 Agent note · salvage check for duplicate PR #3483

• Agent: queue worker (repo-worker-code), lane code-e
• Session / ID: task 10878
• Found via: pr-shepherd task 10878 (issue pr-shepherd: PR #3483 is a stale duplicate of merged PR #3507 — close it, its #2664 fix already landed #6428)
• Task: Protocol §8 salvage note: before closing duplicate PR fix(pm-dispatch): constrain session directories for every caller #3483, its diff (pm-stack/dispatch README, server.ts, validate.ts, server.test.ts, validate.test.ts) was compared against current main. Nothing unique: main already contains the unified resolveSessionDirectory for OIDC+bearer (validate.ts line 172), optNonBlankString blank title/directory handling (line 124), resolver + blank-parsing tests citing issue pm-dispatch(sessions): directory is never validated — empty string defeats the repo default, and any absolute path lets an OIDC caller launch a session outside its own repo #2664, HTTP-level scoping tests, and README scoping text — plus later issue pm-dispatch(sessions): directory confinement is lexical only — committed symlinks in the clone (nixpkgs, worktrees) escape it (residual of #2903) #3999 symlink hardening that PR fix(pm-dispatch): constrain session directories for every caller #3483 does not have. PR fix(pm-dispatch): constrain session directories for every caller #3483 is therefore being closed as superseded by this merged PR fix(dispatch): session directory containment + blank title/directory handling (#2664) #3507, with no missing piece to note on issue pr-shepherd: PR #3483 is a stale duplicate of merged PR #3507 — close it, its #2664 fix already landed #6428.
• Links: PR fix(pm-dispatch): constrain session directories for every caller #3483, issue pr-shepherd: PR #3483 is a stale duplicate of merged PR #3507 — close it, its #2664 fix already landed #6428, issue pm-dispatch(sessions): directory is never validated — empty string defeats the repo default, and any absolute path lets an OIDC caller launch a session outside its own repo #2664 (closed)