[dezren39]

Fixes #2868.

Summary

for each player claim answering this agreement
  ignore unless outcome is "draw" or lowercase hex of either seated player
  only valid claims occupy a position or count toward a fork

Updates compute_state documentation and covers third-party IDs, arbitrary/uppercase outcomes, the draw control, one valid plus one invalid claim, and an ignored claim beside the same player’s valid claim.

Evidence

• Before: task 5449 revalidated the reported behavior at current main 26e2bd411; out-of-domain claims were accepted into concurrence.
• After: cargo test --manifest-path pkgs/id/Cargo.toml --test attestation_poc — 7/7 pass. Changed-file rustfmt --check and git diff --check pass. Package-wide cargo fmt --check reports unrelated formatting differences in untouched files.

Merge Danger

Door: two-way

Blast Radius: narrow — filters invalid outcomes from this PoC state computation; valid seat-hex and draw outcomes retain existing behavior.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 27f87816-dc67-42ba-9ec4-0bfcdfc72db4

Commits

Reviewing files that changed from the base of the PR and between 9f48e29 and 182fdd4.

Files selected for processing: 2

• pkgs/id/src/attestation.rs
• pkgs/id/tests/attestation_poc.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T10:42:26.407982Z	182fdd4	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.