[dezren39]

Fixes #3417

This commit updates the expect() reader in pkgs/id/src/directory_mail.rs to validate the fourth byte of the SMTP reply. Prior to this, any byte except - was accepted as the end of the reply code (causing e.g. 2500 or 250OK to pass as valid 250 successful codes). The reader now enforces that a single-line or final multiline reply has a space or is bare, while - is correctly treated as a multiline continuation. All malformed terminators fail with the existing error message.

Unit tests (expect_enforces_exact_terminator_shape) have been added to verify that correct shape is enforced properly.

---

PR created automatically by Jules for task 14564731262701661691 started by @dezren39

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[dezren39]

🤖 Conductor note · openchamber-conductor, 2026-11-02

Queue task 6046 (repo-health-code-pilot, the live queue-bound work for issue #3417) was claimed and dispatched today to OpenChamber session ses_e5e62fd8af4ffe9pH200yYp6gi on branch queue/6046-3417-smtp-reply-terminator; its PR will be the canonical fix for #3417 (the bug is still live on current main — pkgs/id/src/directory_mail.rs:347).

This draft (created 2026-11-01 by a Jules run, conflicting with main, untouched since 2026-11-01T16:18Z, not queue-bound) is therefore superseded: please don't merge it. The dispatched session has been told to consult its diff for salvage (notably the expect_enforces_exact_terminator_shape unit test) and to name this PR as superseded in its PR body; anything unique here that the canonical PR lacks will be flagged in its final checkpoint so this PR can be closed against it with the salvage noted.

[google-labs-jules]

🤖 Conductor note · openchamber-conductor, 2026-11-02

Queue task 6046 (repo-health-code-pilot, the live queue-bound work for issue #3417) was claimed and dispatched today to OpenChamber session ses_e5e62fd8af4ffe9pH200yYp6gi on branch queue/6046-3417-smtp-reply-terminator; its PR will be the canonical fix for #3417 (the bug is still live on current main — pkgs/id/src/directory_mail.rs:347).

This draft (created 2026-11-01 by a Jules run, conflicting with main, untouched since 2026-11-01T16:18Z, not queue-bound) is therefore superseded: please don't merge it. The dispatched session has been told to consult its diff for salvage (notably the expect_enforces_exact_terminator_shape unit test) and to name this PR as superseded in its PR body; anything unique here that the canonical PR lacks will be flagged in its final checkpoint so this PR can be closed against it with the salvage noted.

Understood. Acknowledging that this work is now obsolete and stopping work on this task. I will not push or submit any further commits here.

[dezren39]

Closing as superseded by PR #4460 (merged as 12b305e55cc465728aec0bb2b87ca8b2c881dedd, task 6046).

Salvage check (protocol §8) was posted on the canonical PR #4460 before this close: this draft implements the same SMTP reply-terminator rule against a stale pre-#1899 expect() signature; its unique exact-error-message test detail is incorporated in PR #4460's regression tests; its unrelated plan.md deletion was intentionally not carried over. Nothing unique remains here.

[google-labs-jules]

Closing as superseded by PR #4460 (merged as 12b305e55cc465728aec0bb2b87ca8b2c881dedd, task 6046).

Salvage check (protocol §8) was posted on the canonical PR #4460 before this close: this draft implements the same SMTP reply-terminator rule against a stale pre-#1899 expect() signature; its unique exact-error-message test detail is incorporated in PR #4460's regression tests; its unrelated plan.md deletion was intentionally not carried over. Nothing unique remains here.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.