Skip to content

docs(seitan): qualify Keybase V2 single-use evidence (#194) - #3768

Merged
dezren39 merged 1 commit into
mainfrom
queue/4803-194-keybase-v2-verification
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4803-194-keybase-v2-verification

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Pin the old-style V2 invite completion path to keybase/client commit 952e87e, including the distinction between sequential committed state and unverified concurrency behavior.
  • Document closed-source team/seitan_v2 behavior as accepted service-level unknowns and explain why local admission does not rely on it.
  • Qualify the older spike and research claims. A real-client accept remains blocked on authorized Keybase account/team access; the exact Drew action is recorded on Seitan V2 (P6.1): check the Keybase server side, old-style invites, and a real accept before P6.3 #194.

Evidence

  • Before: Seitan V2 (P6.1): check the Keybase server side, old-style invites, and a real accept before P6.3 #194 still had an open cross-transaction single-use question, and repository notes overstated Keybase-side serialization.
  • After: module docs cite InviteSeitanV2, transaction completion, active invite state, and handler repoll; the remaining concurrency/server behavior is explicitly bounded as unknown.
  • git diff --check — pass.
  • rustfmt --edition 2024 --check on changed Rust files — pass.
  • CARGO_BUILD_JOBS=4 cargo test --manifest-path pkgs/id/Cargo.toml --no-default-features --features world --lib seitan — 31 passed, 0 failed. The default-feature attempt was terminated by SIGTERM during compilation.
  • Docs-only change; no runtime behavior changed.

Merge Danger

Door: two-way — documentation-only and reversible.

Blast Radius: tiny — comments and research notes; no runtime behavior changes.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 16:03
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2b4689a3-74a8-4cf0-a311-7d532b75bc0a
Commits

Reviewing files that changed from the base of the PR and between 9281c16 and 5ff44b1.

Files selected for processing: 5
  • doc/2026-10-11T03-44-33Z_design_groups_events_delegation/2026-10-11T04-20-17Z_research_findings.md
  • doc/2026-10-11T03-44-33Z_design_groups_events_delegation/spikes/s9-seitan/RESULTS.md
  • doc/2026-10-11T03-44-33Z_design_groups_events_delegation/spikes/s9-seitan/seitan-v2/src/admit.rs
  • pkgs/id/src/seitan/admit.rs
  • pkgs/id/src/seitan/mod.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T16:04:50.336641Z 5ff44b1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit f26e729 into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4803-194-keybase-v2-verification branch November 2, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant