Skip to content

fix(id): mark group join unavailable (#797) - #3782

Merged
dezren39 merged 1 commit into
mainfrom
queue/4853-797-group-join-status
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4853-797-group-join-status

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

 id group join --help
- Join a group with an invitation… Not wired yet.
+ Unavailable: group admission and network joining are not implemented yet.

A valid invitation still fails with an explicit unavailable message, and records no membership. This only makes the CLI status honest; it does not implement invitation acceptance or transport. Refs #797 — the issue stays open for the actual join implementation.

Evidence

  • Before: New tests failed: help only said “Not wired yet,” and a valid ticket reached the ambiguous refusal.
  • After: cargo test --manifest-path pkgs/id/Cargo.toml --test cli_groups — 9 passed, 0 failed; git diff --check and focused rustfmt check pass.

Merge Danger

Door: Two-way; reverting restores the previous help and refusal text.

Blast Radius: Low — id group join help and refusal only.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 16:25
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f54494f1-f4e9-418c-a3b2-7984605bd9cc
Commits

Reviewing files that changed from the base of the PR and between 129642e and c7b4f86.

Files selected for processing: 3
  • pkgs/id/src/cli.rs
  • pkgs/id/src/commands/group.rs
  • pkgs/id/tests/cli_groups.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T16:26:45.204152Z c7b4f86 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit e86afa8 into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4853-797-group-join-status branch November 2, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant