Skip to content

design(id): #787 kitty keyboard raw input - #3812

Merged
dezren39 merged 1 commit into
mainfrom
design/id-787
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
design/id-787

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

#787 issue + pkgs/id evidence
  → decision-ready design note
  → phased, independently mergeable implementation plan

Adds doc/2026-11-01_design_id787.md. Design only; no implementation changes.

Evidence

  • Before: id: Phase 13 F13.5 kitty keyboard protocol on the raw input path #787 had parity/escape/durable-Input acceptance criteria but no committed design record.
  • After: note records options, recommendation, invariants, acceptance tests, phased slices, evidence citations, and explicitly says no Drew questions.
  • Verified: git diff --cached --check; checked 30 pkgs/id file:line citations against this checkout. No implementation tests run (docs-only PR).

Merge Danger

Door: two-way; documentation-only and reversible.

Blast Radius: docs-only.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 16:50
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d9082a3-7b9e-403f-a4fe-7a98892b31e4
Commits

Reviewing files that changed from the base of the PR and between 8bcb8d1 and 1cd7aba.

Files selected for processing: 1
  • doc/2026-11-01_design_id787.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T16:52:24.432518Z 1cd7aba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

Agent note (repo-worker-code · task 6297): picked up PR-shepherd. Revalidated fresh: PR OPEN, MERGEABLE/CLEAN, head 1cd7aba, docs-only (+1 file), no labels. Codex review completed with no findings; CodeRabbit rate-limited (no findings). Next: fresh CI check, then merge under standing authority.

@dezren39
dezren39 merged commit ed9bb0f into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the design/id-787 branch November 2, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant