Skip to content

design(id): #2259 friendly-name references - #3829

Merged
dezren39 merged 2 commits into
mainfrom
design/id-2259
Nov 2, 2026
Merged

dezren39 merged 2 commits into
mainfrom
design/id-2259

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

@/# phrase → authorized local snapshot → ranked candidates + provenance
              → explicit selection → stable-ID reference → preserved-label render

Adds doc/2026-11-01_design_id2259.md, a decision-ready design for the local-store PoC: alternatives and recommendation, reference/index/ranking types, invariants, implementation acceptance criteria, three independently mergeable slices, and two explicit Drew questions. Design-only; no implementation changes. #2259 remains open.

Evidence

Merge Danger

Door: Two-way — a later design can supersede this dated recommendation.

Blast Radius: Documentation only.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 16:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T16:58:26.767503Z 77cf576 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 62e6541e-6718-4a5a-a768-be25689a00d4
Commits

Reviewing files that changed from the base of the PR and between 927f383 and 77cf576.

Files selected for processing: 1
  • doc/2026-11-01_design_id2259.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · picked up

  • Agent: queue worker (repo-worker-code), lane A
  • Session / ID: task 5727
  • Found via: queue claim (resume from park)
  • Task: Resuming task 5727 for issue design(id): #2259 friendly-name references #3829 — implementation is on branch queue/5727-3829-clip-metadata-fanout @587cc919d; the prior targeted test run failed only on process-spawn resource exhaustion at laptop load ~93. Re-running the targeted world:: tests now that load has dropped, then opening the PR.
  • Expectation: effort/m — done = targeted tests green, PR opened for issue design(id): #2259 friendly-name references #3829, task 5727 completed or parked on CI.
  • Links: branch queue/5727-3829-clip-metadata-fanout · issue design(id): #2259 friendly-name references #3829

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · blocked

  • Agent: queue worker (repo-worker-code), lane A
  • Session / ID: task 5727
  • Found via: queue claim
  • Task: Correction — task 5727's packet anchored its work to "design(id): #2259 friendly-name references #3829", but this PR is the unrelated design(id): #2259 friendly-name references design PR. No work for task 5727 was done on this PR by any lane; the pickup notes and queue labels placed here came from that mis-anchored packet.
  • Expectation: done here — task 5727 is blocked in the queue as packet_defect (its target file pkgs/id/src/world/snapshots.rs does not exist on current main, no GitHub issue exists for that B1 work, and the implementation commit its checkpoints recorded exists on no reachable remote or clone). Queue labels are being removed from this PR so it carries no fleet state.

@dezren39 dezren39 added kind/enhancement task/small-fix Queue packet kind: bounded fix with reproduction and targeted tests source/creator Filed by the new-issue-creator job priority/normal Ordinary priority (the default) app/id Package/app: id (pkgs/ or apps/ in this repo) effort/m Medium: expected under 1 day of work and removed status/in-progress Queue worker lifecycle state queue/claimed Queue worker lifecycle state labels Nov 2, 2026
@dezren39
dezren39 merged commit df95f0a into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the design/id-2259 branch November 2, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app/id Package/app: id (pkgs/ or apps/ in this repo) effort/m Medium: expected under 1 day of work kind/enhancement priority/normal Ordinary priority (the default) source/creator Filed by the new-issue-creator job task/small-fix Queue packet kind: bounded fix with reproduction and targeted tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant