Repository navigation
id(world): carry per-connection identity with input (#840) - #3916
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
…input-session-id # Conflicts: # pkgs/id/src/world/actor.rs # pkgs/id/src/world/handle.rs # pkgs/id/src/world/tests.rs # pkgs/id/src/world_session/mod.rs
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
The existing session-less
WorldHandle::inputremains available to internal callers. Session IDs stay out of events and journals.Evidence
WorldCommand::Input; the actor tracked only participant attribution.cargo test --manifest-path pkgs/id/Cargo.toml -p id --lib input_session— pass;... cloned_service_allocates_distinct_ids_for_connections— pass; changed-filerustfmt --check— pass.id-coretest-target error (vt100missing fromid-coredependencies); confirmed the same source/manifest state on clean main.Merge Danger
Door: two-way
Blast Radius: narrow
Only ephemeral input attribution changes; durable event and journal formats are unchanged.
Need help on this PR? Tag
@codesmith-botwith what you need.