Skip to content

id(world): carry per-connection identity with input (#840) - #3916

Merged
dezren39 merged 2 commits into
mainfrom
queue/4860-840-world-input-session-id
Nov 3, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/4860-840-world-input-session-id

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

joined connection
  allocate ephemeral SessionId
  Paste/Input -> WorldHandle::input_from_session
    WorldCommand::Input { session_id }
      WorldActor.acting_session (cleared after input follow-up)

The existing session-less WorldHandle::input remains available to internal callers. Session IDs stay out of events and journals.

Evidence

  • Before: current main had no session field on WorldCommand::Input; the actor tracked only participant attribution.
  • After: cargo test --manifest-path pkgs/id/Cargo.toml -p id --lib input_session — pass; ... cloned_service_allocates_distinct_ids_for_connections — pass; changed-file rustfmt --check — pass.
  • Workspace-wide test selection hits a pre-existing id-core test-target error (vt100 missing from id-core dependencies); confirmed the same source/manifest state on clean main.

Merge Danger

Door: two-way

Blast Radius: narrow

Only ephemeral input attribution changes; durable event and journal formats are unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 18:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T14:13:09.933050Z
We couldn’t complete this review. Comment @codex review to try again.
a653cb9 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d1cf9cd-2532-4c43-8a2c-06a3637a80d0
Commits

Reviewing files that changed from the base of the PR and between d4d7834 and a653cb9.

Files selected for processing: 7
  • pkgs/id/src/world/actor.rs
  • pkgs/id/src/world/handle.rs
  • pkgs/id/src/world/mod.rs
  • pkgs/id/src/world/tests.rs
  • pkgs/id/src/world_session/mod.rs
  • pkgs/id/src/world_session/tests.rs
  • pkgs/id/src/world_session/types.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

…input-session-id

# Conflicts:
#	pkgs/id/src/world/actor.rs
#	pkgs/id/src/world/handle.rs
#	pkgs/id/src/world/tests.rs
#	pkgs/id/src/world_session/mod.rs
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@dezren39
dezren39 merged commit b963332 into main Nov 3, 2026
2 checks passed
@dezren39
dezren39 deleted the queue/4860-840-world-input-session-id branch November 3, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant