Repository navigation
feat(id): package tic-tac-toe as the first apps/ folder + host discovery (#2324) - #3926
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c5973eec2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
df3f836 (#3926) moved the tic-tac-toe example from examples/tic-tac-toe/ to apps/tic-tac-toe/program/ and updated the include_bytes! sites in src/sandbox.rs, but missed the compile-time fixture in tests/worker_poc_reference.rs — which breaks the id test build at main HEAD (found by the #3720 fold switch's toplevel build) — and the same stale path in the worker-poc compare runner. Both now reference apps/tic-tac-toe/program/tic-tac-toe.wasm, which exists.
Implements #2324 (queue task 5769), Phase 1 of the #2028 ID core v1 synthesis: proves the #2026 app-packaging design against the smallest real example.
What changed
pkgs/id/examples/tic-tac-toe/moved (not copied) topkgs/id/apps/tic-tac-toe/:program/(main.roc, tic-tac-toe.wasm, build.sh), README, and a newapp.tomlper the id: investigate: app packaging — apps as folders (code + resources), TUI/web interface parity, web-native specialization #2026 schema ([app],[program] kind = "roc-world",[interfaces.web] mode = "adapter").pkgs/id/src/app_manifest.rs: strict manifest types (deny_unknown_fieldsthroughout) + host-side discovery that enumeratesapps/folders, parsesapp.toml, and rejects unknown fields and folder-name != app id mismatches (design invariants). Registered inlib.rs;serve/sandbox/world_fixtureconsume the packaged layout.cli_integration.rs,attestation_poc.rs,flake.nix,nix/tests/integration-test.nix, roc-world README. New app_manifest tests cover discovery plus malformed-manifest rejection (unknown field, id/folder mismatch).Out of scope (per packet)
Verification
cargo test -p id --lib app_manifeston the laptop (result recorded on task 5769 / id: PoC: package tic-tac-toe as the first apps/ folder — app.toml + host discovery #2324).This branch was implemented by a prior queue lane and committed/pushed by lane F on resume, per the fleet resume-don't-restart rule.
Need help on this PR? Tag
@codesmith-botwith what you need.