Repository navigation
feat(aggregator): comments queue view, kind-aware badge counts, honest failure copy (#1210) - #3987
Conversation
|
@codex review |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Implements #1210 (task 4922) in pm-stack/aggregator.
Queue view — new manifest page "Comments queue" (
/comments, dropdown tier in the #1497 table, recorded in curation-1497.test.ts per the Alerts precedent) with machine twin/api/comments/queue.json. It lists every comment still waiting on a loop — messages with triageState "new" and GitHub comments "pending" or "failed" — oldest first, each with kind chip, object ref, age, and a thread link. Notes and terminal comments (triaged/posted) never appear. Reachable in 2 clicks via the Pages dropdown / All pages.Kind/state-aware counts —
commentKindCounts()+CommentsStore.countsDetailed()(per object: notes / messages / messagesNew / github / githubPending / githubFailed / actionable). Badge sources in server.ts now use the detailed counts;commentBadgerenders💬 N · M queuedwith a title breaking the total down by kind/state. Plain number counts keep the original badge rendering.Honest failure copy — a failed GitHub comment now renders
posting failed <age> — no automatic retry exists; a fleet poster must post it by hand — last error: …. The error is real data now:DashComment.githubErroris persisted bymarkGithubResulton error reports (refreshed on repeat failures, cleared when the comment posts) — previously the reported error was discarded entirely.Tests — new test/comments-queue-1210.test.ts (9 tests): queue contents/ordering/omissions, counts by kind/state, badge rendering (detailed + plain), failed-state copy (age + last error, no "will retry"), queue page rendering + manifest registration, and githubError persistence across store reload. Full suite on the laptop: 923 pass / 1 fail — the one failure is slice3's registry assertion, proven identical on clean main (70a595a) and already tracked as #3835.
tsc --noEmitoutput is identical to the clean-main baseline (12 pre-existing errors, none in touched files).Refs #1210.
Need help on this PR? Tag
@codesmith-botwith what you need.