Skip to content

feat(aggregator): comments queue view, kind-aware badge counts, honest failure copy (#1210) - #3987

Merged
dezren39 merged 1 commit into
mainfrom
queue/4922-1210-comments-queue
Nov 1, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/4922-1210-comments-queue

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Implements #1210 (task 4922) in pm-stack/aggregator.

Queue view — new manifest page "Comments queue" (/comments, dropdown tier in the #1497 table, recorded in curation-1497.test.ts per the Alerts precedent) with machine twin /api/comments/queue.json. It lists every comment still waiting on a loop — messages with triageState "new" and GitHub comments "pending" or "failed" — oldest first, each with kind chip, object ref, age, and a thread link. Notes and terminal comments (triaged/posted) never appear. Reachable in 2 clicks via the Pages dropdown / All pages.

Kind/state-aware counts — commentKindCounts() + CommentsStore.countsDetailed() (per object: notes / messages / messagesNew / github / githubPending / githubFailed / actionable). Badge sources in server.ts now use the detailed counts; commentBadge renders 💬 N · M queued with a title breaking the total down by kind/state. Plain number counts keep the original badge rendering.

Honest failure copy — a failed GitHub comment now renders posting failed <age> — no automatic retry exists; a fleet poster must post it by hand — last error: …. The error is real data now: DashComment.githubError is persisted by markGithubResult on error reports (refreshed on repeat failures, cleared when the comment posts) — previously the reported error was discarded entirely.

Tests — new test/comments-queue-1210.test.ts (9 tests): queue contents/ordering/omissions, counts by kind/state, badge rendering (detailed + plain), failed-state copy (age + last error, no "will retry"), queue page rendering + manifest registration, and githubError persistence across store reload. Full suite on the laptop: 923 pass / 1 fail — the one failure is slice3's registry assertion, proven identical on clean main (70a595a) and already tracked as #3835. tsc --noEmit output is identical to the clean-main baseline (12 pre-existing errors, none in touched files).

Refs #1210.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 21:11
@dezren39

dezren39 commented Nov 1, 2026

Copy link
Copy Markdown
Member Author

@codex review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b381818-78ee-45cd-a09b-c66b40b9f8fd
Commits

Reviewing files that changed from the base of the PR and between 70a595a and cac2674.

Files selected for processing: 7
  • pm-stack/aggregator/src/comments.ts
  • pm-stack/aggregator/src/model.ts
  • pm-stack/aggregator/src/pages.ts
  • pm-stack/aggregator/src/render.ts
  • pm-stack/aggregator/src/server.ts
  • pm-stack/aggregator/test/comments-queue-1210.test.ts
  • pm-stack/aggregator/test/curation-1497.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T21:13:32.664992Z cac2674 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: cac2674fb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dezren39
dezren39 merged commit 2f8ab78 into main Nov 1, 2026
1 check passed
@dezren39
dezren39 deleted the queue/4922-1210-comments-queue branch November 1, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant