Repository navigation
feat(aggregator): roadmap annotations (#1284) - #4054
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bd25ded6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .filter(Boolean), | ||
| feedFile: s(env.PM_AGG_FEED_FILE, join(process.cwd(), "fleet-feed.json")), | ||
| commentsFile: s(env.PM_AGG_COMMENTS_FILE, join(process.cwd(), "comments.json")), | ||
| roadmapAnnotationsFile: s(env.PM_AGG_ROADMAP_ANNOTATIONS_FILE, join(process.cwd(), "roadmap-annotations.json")), |
There was a problem hiding this comment.
Keep annotation state outside the deployed Git checkout
On the NixOS deployment, the first annotation creates an unignored pm-stack/aggregator/roadmap-annotations.json inside the primary checkout: nixos/services/pm-stack/default.nix sets that directory as WorkingDirectory but does not set the new environment variable. pm-stack/scripts/pm-git-sync.sh:42–47 explicitly exits without pulling whenever the working tree contains dirt, so using this feature blocks subsequent automatic updates and deployments until someone manually relocates or ignores the file. Wire the annotation path to the aggregator state directory in the deployed service, as already done for the coverage snapshot.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed: the deployed aggregator service in nixos/services/pm-stack/default.nix now sets PM_AGG_ROADMAP_ANNOTATIONS_FILE=${aggState}/roadmap-annotations.json, wired exactly like PM_AGG_COVERAGE_SNAPSHOT_FILE, so annotation state lives in ~/.local/state/pm-aggregator/ and never dirties the deployed checkout / blocks pm-git-sync. Verified: nix file parses (nix-instantiate --parse), bun test test/roadmap-annotations.test.ts 2/2 pass, slice3 annotation coverage passes (the one slice3 failure is the pre-existing env-dependent routes/registry baseline reproduced on clean main by earlier shifts, unrelated — the bun suites do not read the .nix file). — task 5002, lane F
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Adds a separate durable JSON store; annotations are dated, attributed, immutable, and sorted by annotation date. The alias endpoint maps a reshuffled current row to an existing stable ref without rewriting history.
Evidence
bun test test/roadmap-annotations.test.ts test/roadmap-drill.test.ts— 7 passed.bun test test/slice3.test.ts -t 'roadmap annotations round-trip'— 1 passed.main.bunx tsc --noEmitreports existing unrelated diagnostics in other tests and theweb-pushdeclaration; no diagnostics point to changed annotation files.Merge Danger
Door: two-way
Blast Radius: aggregator — roadmap storage, item/timeline rendering, and
/api/roadmap.json.Closes #1284.
Need help on this PR? Tag
@codesmith-botwith what you need.