Skip to content

fix(id): align world-doctor journal behavior - #4068

Merged
dezren39 merged 3 commits into
mainfrom
queue/5082-2093-align-world-doctor-journal-verdict
Nov 2, 2026
Merged

dezren39 merged 3 commits into
mainfrom
queue/5082-2093-align-world-doctor-journal-verdict

Conversation

@dezren39

@dezren39 dezren39 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

 FileJournal::open
+  skip blank lines
   reject malformed complete entries
   drop incomplete final append

world-doctor
+  warn when an incomplete final append will be dropped
+  distinguish unsupported newer-format advice

Closes #2093.

Evidence

  • cargo test --no-default-features --features world --lib world_doctor::tests — 14 passed.
  • cargo test --no-default-features --features world --lib world_store::tests — 22 passed.
  • rustfmt --check --edition 2024 pkgs/id/src/world_doctor.rs pkgs/id/src/world_store.rs and git diff --check pass.
  • GitHub has not reported build checks; Codex review is pending.

Merge Danger

Door: Two-way

Blast Radius: low

Only journal parsing and doctor advice change; malformed newline-terminated entries remain fatal.

@dezren39
dezren39 requested a review from a team as a code owner November 1, 2026 23:23
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: de33f155-9dfa-4e38-8aa9-6575362cd35d
Commits

Reviewing files that changed from the base of the PR and between 20087ab and 69f119f.

Files selected for processing: 2
  • pkgs/id/src/world_doctor.rs
  • pkgs/id/src/world_store.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T05:35:46.686636Z 69f119f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 69f119fde0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dezren39
dezren39 merged commit b7cc535 into main Nov 2, 2026
14 of 33 checks passed
@dezren39
dezren39 deleted the queue/5082-2093-align-world-doctor-journal-verdict branch November 2, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant