Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2143 (queue task 5188): a read-only web page for the local
crate::groupsevent-log projection, distinct from the hosted-world directory groups at/explore.Changes (
pkgs/id)src/web/groups.rs(new) —GET /groupshandler + rendering:read_projection()parses the group log itself with the same torn-tail tolerance asGroupLog::open(an unparseable final line without a trailing newline is ignored; a corrupt complete line is an error) but never writes: a page GET cannot truncate or repair the log.Projection::grants_in_force()— so a grant whose grantor was later removed still shows while in force (grantor, grantee, scope, redelegable, target world).WebSecurityguard applies unchanged (the route is registered in the same router).src/web/mod.rs—AppState.groups_log: Option<PathBuf>, threaded throughweb_router/web_router_with_local_events/finish_routerexactly like the world/cookie settings.src/web/routes.rs— registers/groups.src/commands/serve.rs— both web-router call sites passSome(serve_groups_log_path(groups_log)), i.e. the same--groups-logresolution (override or defaultgroups.jsonl) the warning watcher already uses.Tests (laptop,
--features web)cargo test --lib web::groups— 5/5: retained grant from a removed grantor stays visible (grant + member-role rendering), torn-tail read leaves the file byte-identical, missing log file renders as empty, corrupt complete line errors, configured-path/default resolution.web::andcommands::servemodule runs on the laptop (see PR checks / CI for the full suite).Note: the sandbox worktree needs the gitignored frontend artifact
pkgs/id/web/distpresent to compile thewebfeature (RustEmbed); it was copied from the primary clone's build output for the local test run and is not part of this change.Need help on this PR? Tag
@codesmith-botwith what you need.