Skip to content

feat(id): read-only local groups and grants web page at /groups (#2143) - #4107

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/5188-2143-groups-page
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/5188-2143-groups-page

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Implements #2143 (queue task 5188): a read-only web page for the local crate::groups event-log projection, distinct from the hosted-world directory groups at /explore.

Changes (pkgs/id)

  • src/web/groups.rs (new) — GET /groups handler + rendering:
    • read_projection() parses the group log itself with the same torn-tail tolerance as GroupLog::open (an unparseable final line without a trailing newline is ignored; a corrupt complete line is an error) but never writes: a page GET cannot truncate or repair the log.
    • Renders every group with its ID and active/dissolved status, direct member keys and roles, and the grants in force via Projection::grants_in_force() — so a grant whose grantor was later removed still shows while in force (grantor, grantee, scope, redelegable, target world).
    • No write actions; the existing WebSecurity guard applies unchanged (the route is registered in the same router).
  • src/web/mod.rs — AppState.groups_log: Option<PathBuf>, threaded through web_router / web_router_with_local_events / finish_router exactly like the world/cookie settings.
  • src/web/routes.rs — registers /groups.
  • src/commands/serve.rs — both web-router call sites pass Some(serve_groups_log_path(groups_log)), i.e. the same --groups-log resolution (override or default groups.jsonl) the warning watcher already uses.

Tests (laptop, --features web)

  • cargo test --lib web::groups — 5/5: retained grant from a removed grantor stays visible (grant + member-role rendering), torn-tail read leaves the file byte-identical, missing log file renders as empty, corrupt complete line errors, configured-path/default resolution.
  • Broader web:: and commands::serve module runs on the laptop (see PR checks / CI for the full suite).

Note: the sandbox worktree needs the gitignored frontend artifact pkgs/id/web/dist present to compile the web feature (RustEmbed); it was copied from the primary clone's build output for the local test run and is not part of this change.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 01:16
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fceb1947-b837-4b24-af81-88c1753e0dad
Commits

Reviewing files that changed from the base of the PR and between d963623 and 8e14ed7.

Files selected for processing: 4
  • pkgs/id/src/commands/serve.rs
  • pkgs/id/src/web/groups.rs
  • pkgs/id/src/web/mod.rs
  • pkgs/id/src/web/routes.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T01:18:40.063665Z 8e14ed7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant