Skip to content

fix(dispatch): guard post-claim GitHub annotations independently (#2660) - #4231

Merged
dezren39 merged 1 commit into
mainfrom
queue/5414-2660-guard-post-claim-annotations
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5414-2660-guard-post-claim-annotations

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Fixes #2660 (queue task 5414; design #2668 phase 2).

What

PR #2911 made post-claim GitHub annotations best-effort so a failure no longer rejects a live launch, but the issue comment and label calls shared one try/catch: a failed comment silently skipped the labels, and a wait:true caller saw a clean success with no warning.

  • New pm-stack/dispatch/src/launch_annotations.ts — annotateLaunch runs the comment and labels each in its own guard, following the launch_failure.ts extraction pattern. Each failure is recorded on the task (last_error, accumulating so the final note names every failure) and returned as a warning; the remaining steps still run; the launch is never rejected.
  • launchSession now takes the response warnings array and pushes annotation warnings into it, so the wait:true 201 surfaces them; the wait:false 202 path records failures on the task as before. Pre-commit failure semantics (fix(pm-dispatch): wait:false launch failures leave the queue task queued and the issue unnoted #2901) untouched.
  • README truth-up per the design decision: the flow section gains the commit-point stage/failure semantics and the invariant sentence now reads "nor claimed-and-running reported as failed".

Tests

  • New test/launch_annotations.test.ts (5 stubbed-client tests): both succeed; comment fails → labels still attempted + warning + task note; labels fail → warning + note; both fail → two warnings and the final note names both; task-note failure does not reject. Both wait modes reach the helper through the single launchSession path.
  • bun test in pm-stack/dispatch: 105 pass, 0 fail. tsc --noEmit clean for the touched files (one pre-existing error in untouched test/queue.test.ts remains).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 06:46
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7b0d0cc-7d63-4a09-a11c-fa34217ba3e0
Commits

Reviewing files that changed from the base of the PR and between 076d22c and 8500d47.

Files selected for processing: 4
  • pm-stack/dispatch/README.md
  • pm-stack/dispatch/src/launch_annotations.ts
  • pm-stack/dispatch/src/server.ts
  • pm-stack/dispatch/test/launch_annotations.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T06:47:40.066590Z 8500d47 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant