Skip to content

fix(id): plain_field escapes the shared Unicode 16 Cf set (#2839) - #4264

Merged
dezren39 merged 1 commit into
mainfrom
queue/5439-2839-plain-field-unicode-cf
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5439-2839-plain-field-unicode-cf

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Implements issue #2839 (queue task 5439).

  • Promotes the complete Unicode 16 Cf range predicate from petname.rs into one shared pub(crate) definition in id-core (new unicode.rs); no renderer-local subset.
  • plain_field now treats every shared Cf character as a quote trigger and escapes it as a JSON-compatible \uXXXX sequence, including when already quoting for tab/newline — no raw Cf remains in rendered fields.
  • Regression tests cover override-only input and override combined with tab, exercising the shared Cf set (U+200B–U+200D, U+FEFF, U+00AD, U+2060).

Verification status: rustfmt check and git diff --check pass (prior shift). Focused cargo tests (commands::text::tests, id-core) were still compiling when the prior shift parked, and the laptop is currently under heavy load, so the test run is being carried by CI on this PR; the task is parked awaiting CI and will be merged only on green checks plus a clean Codex round.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 07:43
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 10882ca7-ceb5-44fd-afc1-167bf1b1e64c
Commits

Reviewing files that changed from the base of the PR and between ddd0d42 and 90782ce.

Files selected for processing: 5
  • pkgs/id/crates/id-core/src/lib.rs
  • pkgs/id/crates/id-core/src/petname.rs
  • pkgs/id/crates/id-core/src/unicode.rs
  • pkgs/id/src/commands/text.rs
  • pkgs/id/src/lib.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T07:45:44.670809Z 90782ce PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant