Repository navigation
fix(id): widen base+U+FE0F only for emoji-presentable bases (#3265) - #4355
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3265. Queue task 5693.
What
graphemeWidthinpkgs/id/web/src/world-surface.tsreturned 2 for every cluster containing U+FE0F. It now widens only when the code point immediately before U+FE0F can start an emoji presentation sequence; otherwise U+FE0F measures 0 in the plain sum (letter+FE0F = 1, lone FE0F = 0).The gate table (
EMOJI_PRESENTATION_SEQ_RANGES, 183 ranges / 371 code points) was decoded verbatim from unicode-width 0.2.2'sstarts_emoji_presentation_seqbit table (EMOJI_PRESENTATION_LEAVESin the crate's tables.rs) — the exact set the Rust validator widens, not a hand-picked approximation.Tests
bunx vitest run src/world-surface.test.ts— 11/11 pass, including a new parity test: narrow cases (a/x/Z/é/Ω/→/!/?/%/space+ FE0F and ©+U+0301+FE0F at columns 1; lone FE0F refused at both widths) and wide cases (9️⃣) still at columns 2.unicode-width = "=0.2.2"): 14,607 base+FE0F clusters (U+0020–U+32FF, U+1F000–U+1F64F) + 8 special sequences (keycaps, mark-interrupted, lone/double FE0F, ☝️, ❤️🔥) — zero FE0F-effect mismatches (cluster width minus base-alone width agrees on every case) and 8/8 specials exact. The 127 raw cluster mismatches are fully inherited from base-alone divergences (CJK radical/unassigned points, trigrams, Khmer, zero-width classes) — that is the single-code-point scope of id(web): world presenter residual width divergences vs unicode-width 0.2.2 — 2529 code points in classes #1581 never scoped (trigrams, CJK radicals, format chars) #2962, explicitly out of this packet.Dispositions
graphemeWidthcomment as unreachable from valid wire data — the server never emits a width-0 grapheme as a cell; width-0 cells only ever appear as empty-symbol continuation cells. No behaviour change.Need help on this PR? Tag
@codesmith-botwith what you need.