Skip to content

fix(id): widen base+U+FE0F only for emoji-presentable bases (#3265) - #4355

Merged
dezren39 merged 1 commit into
mainfrom
queue/5693-3265-fe0f-width
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5693-3265-fe0f-width

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Fixes #3265. Queue task 5693.

What

graphemeWidth in pkgs/id/web/src/world-surface.ts returned 2 for every cluster containing U+FE0F. It now widens only when the code point immediately before U+FE0F can start an emoji presentation sequence; otherwise U+FE0F measures 0 in the plain sum (letter+FE0F = 1, lone FE0F = 0).

The gate table (EMOJI_PRESENTATION_SEQ_RANGES, 183 ranges / 371 code points) was decoded verbatim from unicode-width 0.2.2's starts_emoji_presentation_seq bit table (EMOJI_PRESENTATION_LEAVES in the crate's tables.rs) — the exact set the Rust validator widens, not a hand-picked approximation.

Tests

  • bunx vitest run src/world-surface.test.ts — 11/11 pass, including a new parity test: narrow cases (a/x/Z/é/Ω/→/!/?/%/space + FE0F and ©+U+0301+FE0F at columns 1; lone FE0F refused at both widths) and wide cases (⚠️ ☝️ ❤️ ©️ ®️ ™️ ♠♥♦ ▶◀ ↔↩⤴ 〰〽㊗㊙, digit/#/* + FE0F, keycap 9️⃣) still at columns 2.
  • Differential probe (real TS width machinery extracted verbatim vs a Rust probe pinned to unicode-width = "=0.2.2"): 14,607 base+FE0F clusters (U+0020–U+32FF, U+1F000–U+1F64F) + 8 special sequences (keycaps, mark-interrupted, lone/double FE0F, ☝️, ❤️‍🔥) — zero FE0F-effect mismatches (cluster width minus base-alone width agrees on every case) and 8/8 specials exact. The 127 raw cluster mismatches are fully inherited from base-alone divergences (CJK radical/unassigned points, trigrams, Khmer, zero-width classes) — that is the single-code-point scope of id(web): world presenter residual width divergences vs unicode-width 0.2.2 — 2529 code points in classes #1581 never scoped (trigrams, CJK radicals, format chars) #2962, explicitly out of this packet.

Dispositions


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 12:14
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c91d2e9-f69a-4b10-a13d-b15142785a7d
Commits

Reviewing files that changed from the base of the PR and between f12f5b7 and 382eb52.

Files selected for processing: 2
  • pkgs/id/web/src/world-surface.test.ts
  • pkgs/id/web/src/world-surface.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T12:16:53.702358Z 382eb52 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant