Skip to content

test(codex-proxy): serve model catalog in CLI stub - #4367

Merged
dezren39 merged 1 commit into
mainfrom
queue/5713-3769-codex-proxy-tests-hang
Nov 2, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/5713-3769-codex-proxy-tests-hang

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

 codex test stub
+if args are `debug models`, return a valid catalog immediately
 prompt=$(cat)

execFile leaves child stdin open; the stub previously blocked in cat until the proxy's 30-second model-lookup timeout. This delayed every chat request and made the first test take about 60 seconds. Closes #3769.

Evidence

Merge Danger

Door: two-way

Blast Radius: test-only


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 13:02
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aaded4e6-1f64-445a-becf-e6b10ad8ce20
Commits

Reviewing files that changed from the base of the PR and between 3776e6d and ce6757f.

Files selected for processing: 1
  • bin/codex-proxy.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T13:03:46.056662Z ce6757f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit a019c8d into main Nov 2, 2026
1 check passed
@dezren39
dezren39 deleted the queue/5713-3769-codex-proxy-tests-hang branch November 2, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant