Repository navigation
feat(openclaw): enable memory-lancedb with fixed local embedding endpoint (#1300 phase 1) - #4451
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of #1300 (queue task 5001,
repo-health-code-pilot, workerrepo-worker-code, Lane E). Phase 2 (fleet vector-store decision) is untouched and stays on #1300.Plugin identity — verified against the catalog: the pinned nix-openclaw catalog (rev
4e5f4446,nix/generated/openclaw-runtime-plugins/memoryLancedb.nix) hasmemoryLancedbwith idmemory-lancedb,catalogSource = "official", package@openclaw/memory-lancedbv2026.10.7. That is the plugin enabled here.Change (
home/openclaw/default.nix, +52/−1):runtimePluginsgains"memory-lancedb".plugins.slots.memory = "memory-lancedb"(reversible: remove the slot line + plugin to fall back to the built-in memory backend) and aplugins.entries."memory-lancedb"entry: direct OpenAI-compatible embedding path,autoRecall = true,autoCapture = false.openclaw-embedding.service(systemd user unit) runs llama-server--embeddingon the fixed loopback port 18791, reusing the llama.cpp b11669 binary andQwen3-Embedding-0.6B-Q8_0.ggufalready cached under~/.cache/opencodeby OpenCode's messaging embeddings (its own per-process servers use dynamic ports a static config cannot point at — the gap recorded on Roadmap: vector memory for OpenClaw (memory-lancedb now, fleet vector store later?) #1300).ConditionPathExistson the GGUF makes a cleared cache fail loudly. The gateway unit now startsAfter+Wantsit.baseUrl http://127.0.0.1:18791/v1, modelQwen3-Embedding-0.6B-Q8_0,dimensions = 1024, placeholder apiKey label (loopback server checks no key — same posture as the existinglocalProvider).Verified this shift (laptop):
nix-instantiate --parse home/openclaw/default.nix— OK.POST /v1/embeddingsreturned a 1024-dimension vector with modelQwen3-Embedding-0.6B-Q8_0. Probe server stopped afterwards; port free.Not yet done (why this is not merged yet): full module evaluation + the home-manager switch and the live gateway store/recall round-trip (
openclaw plugins inspect memory-lancedb --runtime,openclaw ltmstore/search) still need a low-load window — the laptop was at load ~136 from other fleet builds during this shift. Task 5001 is parked on that resume condition with this PR as the artifact.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.