Repository navigation
Phase 3b (#3456): plain-output contract statement + terminal_text strips Cf - #4458
Merged
Merged
Conversation
…ips Cf Contract (#3455): a plain-text field is row-safe only with no structure character (Cc + U+2028/U+2029) and no format character (shared Cf set). Disposition by surface kind: row renderers escape, stripping sanitizers strip, ingest validators refuse. Shared set home: id-core unicode.rs, Unicode 16. Fix: world_ssh terminal_text also strips crate::is_format_char (was Cc-only), with regression tests. All other inventory sites verified conformant or deliberately-local; web/identity sanitize_name filed as a follow-up (partial Cf strip).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the code-change half of #3456 (design #3455 Phase 3b audit). The inventory table and closing evidence are posted as comments on #3456 / #3455; this PR carries the doc change plus the one site dispositioned as needing a fix on this branch.
Changes
pkgs/id/src/commands/text.rsmodule doc: the plain-output contract statement — two character classes (structure Cc + U+2028/U+2029; format Cf), disposition-by-surface-kind rule (row renderers escape / stripping sanitizers strip / ingest validators refuse), shared Cf home (crate::is_format_charinid-core/src/unicode.rs) + Unicode version (16).pkgs/id/src/world_ssh.rsterminal_text: strip the shared Cf set in addition to Cc (was Cc-only, keep LF/TAB). Terminal output is the contract's core threat surface — one participant's text must not reorder another's terminal. Documented cost: ZWJ-joined emoji render as separate glyphs here; stored text untouched.terminal_text_drops_format_characters_but_keeps_layout.Inventory summary (full table on #3456)
terminal_text(strip Cf).plain_field/group::text(Phases 1-2, escape);sanitize_display_name/sanitize_chat(strip Cf, chat keeps ZWJ/ZWNJ);clean_name/clean_description(refuse-Cf, replay-only exception for pre-id(directory): format characters (Cf) bypass clean_name/clean_description — U+202E and U+200B pass the 'no control characters' rule for account and group names #1778 journals);invite(refuse-Cf);petname(the mould).legacy_sanitize_display_name(pre-id(world): sanitize_display_name / sanitize_chat filter Cc only — Cf format characters (U+202E, U+200B, bidi isolates) pass into participant names and broadcast chat, and a zero-width-only name passes the join empty check #2112 journal compat, restore-only);parse_recordskeys; mail subject (SMTP-injection gate, sink-only); SSH target parse; public-document name gate;normalize_paste(program input, Cf/ZWJ legitimate); link-destination grammar (CommonMark predicate);world_capsrequest ids;world_presentationgrapheme/width gates (Cf refusal would reject legitimate ZWJ emoji screens).web/identity sanitize_namepartial Cf strip).Verification
rustfmt --checkclean on both files. Full test verification via CI on this PR (per queue-task discipline); new + existing terminal/text tests cover the change.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.