Repository navigation
fix(id/web): presenter width parity for the 2372 reachable code points (#2962) - #4491
Merged
Merged
Conversation
#2962) Sync WIDE_RANGES in world-surface.ts with unicode-width 0.2.2 for the three reachable singleton classes found by the exhaustive differential (task 4251): rust=2/ts=1 points (2295, e.g. trigrams U+2630..U+2637, Khmer U+17A4, Yi U+A000..U+A4C6) now measure 2; rust=1/ts=2 points (76 CJK radicals inside the broad 0x2E80..0x303E / 0x3040..0x33FF ranges and tail carve-outs) now measure 1 via split ranges; U+2D7F measures 1 despite being Mn/Grapheme_Extend. Verified by re-running the exhaustive differential over U+0020..U+2FFFF (alone and +U+FE0E): reachable mismatches are now zero; the residual is exactly the 156 unreachable-alone points (rust=0: 143 at ts=1 and 12 at ts=2, plus U+17D8 at rust=3). New regression test covers representatives of each class; world-surface suite 12/12.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2962 (fix task 5514; triage task 4251).
Syncs the
WIDE_RANGEStable inpkgs/id/web/src/world-surface.tswith Rust unicode-width 0.2.2 for the three reachable singleton classes:0x2E80..0x303E/0x3040..0x33FFwide ranges (e.g. U+2E9A, U+2EF4..U+2EFF) plus tail carve-outs in the Hangul-jamo and halfwidth ranges, expressed as split ranges so the table stays the single source of truthcodePointWidth: it is Mn/Grapheme_Extend but width 1 in unicode-width 0.2.2)Verification — exhaustive differential re-run (Rust probe pinned to unicode-width =0.2.2,
scan.tsvover U+0020..U+2FFFF; BungraphemeWidthfrom the patched file), alone and +U+FE0E:Tests: new regression test in
world-surface.test.tscovers representatives of each class throughrenderWorldSurface;vitest run src/world-surface.test.ts12/12 pass on the laptop. Note:tsc --noEmitshows one pre-existing error insrc/image-upload.test.ts:429(untouched by this PR, present in the worktree install).Scope stays exactly as triaged: cluster/FE0F behaviour is #3265's, the rust=0/rust=3 classes are documented no-ops.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.