Skip to content

fix(acp): scope streamed-text offsets per session - #4629

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/6534-4616-acp-session-offsets
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/6534-4616-acp-session-offsets

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Summary

-partTextSent: Map<partId, offset>
+partTextSent: Map<sessionId, Map<partId, offset>>

-finishPrompt(sessionId) -> clear all offsets
+finishPrompt(sessionId) -> delete only that session

The stub serve now supports multiple ACP sessions, with a regression that completes session A between session B's cumulative text updates.

Evidence

  • Before: finishing A cleared B's offset; B could emit Hello again with its next cumulative update.
  • After: node --test bin/opencode-acp-adapter.test.mjs — 6 passed, 0 failed; B receives Hello, then world.
  • node --check bin/opencode-acp-adapter.mjs and git diff --check pass.

Merge Danger

Door: Two-way.

Blast Radius: Contained to ACP adapter text-stream bookkeeping and its test harness.

Closes #4616.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 22:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T22:37:49.482885Z ad63146 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6a80f91-cff3-42f5-a194-72fa76cbc099
Commits

Reviewing files that changed from the base of the PR and between 2f62ce6 and ad63146.

Files selected for processing: 2
  • bin/opencode-acp-adapter.mjs
  • bin/opencode-acp-adapter.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openclaw ACP adapter: finishPrompt clears streamed-text offsets for all sessions, duplicating the still-running session's text (#3997)

1 participant