Repository navigation
Conversation
Remaining store-path bin refs in home/common/default.nix baked the eval-time bin/ tree into the store, the same class that served the pre-Oct-24 tree in #883. The proxy units already moved to $HOME/code/bin checkout paths (#2107); migrate the last eight sites (sync-models oneshot plus clef/agy/codex/antigravity-ls/design-code and sync-models/update-models shims) the same way so they track the live checkout instead of a snapshot.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🤖 Agent note · probe results — stale pin named (task 6513, PR #4673)
|
|
🤖 Agent note · supplement — shim build verification (task 6513)
|
Fixes #883 (remaining store-path refs; deploy stays with operator).
Root cause named: the stale-tree pin is not a flake input —
lib/default.nix:22-27(root = inputs.self.outPath) is self-consistent and no second copy of this repo exists inflake.nixinputs. It is the path-anchored interpolation${../../bin}inhome/common/default.nix: Nix snapshots the eval-timebin/directory into the store, bypassingroot/from-rootentirely. Evidence from the live machine (read-only, no build): deployedsync-models.serviceembeds a storesync-models.mjsmatching Oct-30b0058ec7(28137 vs 26654 bytes vs checkout), and the deployedclef-proxywrapper points at a Nov-1 store-bin/containing 6 residue files (*.bak*,.pre-warm-*,.new) committed Oct-25 by11fc50d2eand deleted Nov-2 by82225058b— i.e. the Nov-1 HM switch snapshotted working-state residue via${../../bin}. Assembly chain verified:flake.nixamd →nixos/init→nixos/users/user→home/user→home/common(+ 9 amd fragments innixos/hosts/default.nix).Change: migrate the last 8 sites to $HOME/code/bin checkout paths, following #2107: sync-models oneshot timer (:892) plus the 7
writeShellScriptBinshims (clef/agy/codex/antigravity-ls/design-code, sync-models, update-models). After this change a repo-wide grep for../../binin *.nix under home/, nixos/, lib/, pkgs/ is clean (comments only).Verified:
nix-instantiate --parse home/common/default.nixOK;treefmt --fail-on-changeclean; zero remaining interpolations.Not verified here (operator/CI): full
nixosConfigurations.amdbuild from clean HEAD, post-switch 203/EXEC check, managed-opencode rev check. Queue task 6513.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.