Skip to content

fix(home): run sync-models and proxy shims from checkout bin (#883) - #4673

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/6513-883-name-home-bin-pin
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/6513-883-name-home-bin-pin

Conversation

@dezren39

@dezren39 dezren39 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Fixes #883 (remaining store-path refs; deploy stays with operator).

Root cause named: the stale-tree pin is not a flake input — lib/default.nix:22-27 (root = inputs.self.outPath) is self-consistent and no second copy of this repo exists in flake.nix inputs. It is the path-anchored interpolation ${../../bin} in home/common/default.nix: Nix snapshots the eval-time bin/ directory into the store, bypassing root/from-root entirely. Evidence from the live machine (read-only, no build): deployed sync-models.service embeds a store sync-models.mjs matching Oct-30 b0058ec7 (28137 vs 26654 bytes vs checkout), and the deployed clef-proxy wrapper points at a Nov-1 store -bin/ containing 6 residue files (*.bak*, .pre-warm-*, .new) committed Oct-25 by 11fc50d2e and deleted Nov-2 by 82225058b — i.e. the Nov-1 HM switch snapshotted working-state residue via ${../../bin}. Assembly chain verified: flake.nix amd → nixos/init → nixos/users/user → home/user → home/common (+ 9 amd fragments in nixos/hosts/default.nix).

Change: migrate the last 8 sites to $HOME/code/bin checkout paths, following #2107: sync-models oneshot timer (:892) plus the 7 writeShellScriptBin shims (clef/agy/codex/antigravity-ls/design-code, sync-models, update-models). After this change a repo-wide grep for ../../bin in *.nix under home/, nixos/, lib/, pkgs/ is clean (comments only).

Verified: nix-instantiate --parse home/common/default.nix OK; treefmt --fail-on-change clean; zero remaining interpolations.

Not verified here (operator/CI): full nixosConfigurations.amd build from clean HEAD, post-switch 203/EXEC check, managed-opencode rev check. Queue task 6513.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Remaining store-path bin refs in home/common/default.nix baked the
eval-time bin/ tree into the store, the same class that served the
pre-Oct-24 tree in #883. The proxy units already moved to
$HOME/code/bin checkout paths (#2107); migrate the last eight sites
(sync-models oneshot plus clef/agy/codex/antigravity-ls/design-code and
sync-models/update-models shims) the same way so they track the live
checkout instead of a snapshot.
@dezren39
dezren39 requested a review from a team as a code owner November 3, 2026 00:11
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b83c5413-40b9-401a-9691-8264fc22c5cd
Commits

Reviewing files that changed from the base of the PR and between f84fc37 and 892f5a1.

Files selected for processing: 1
  • home/common/default.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T00:12:48.965525Z 892f5a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · probe results — stale pin named (task 6513, PR #4673)

  • Agent: repo-worker-code (opencode lane, session ses_e5e5f822132ffegLLPlcfg2x6r)
  • Pin named: inputs.self.outPath (lib/default.nix:22-27), captured at the nixos-rebuild eval that built the booted generation. No second flake input exists: ${../../bin/...} in home/common/default.nix and lib.from-root "bin/..." both resolve to ${self.outPath}/bin/.... Nix copies that tree into /nix/store at eval time, freezing the checkout's tree into the generation until the next switch.
  • Eval probe on amd (discriminating):
  • Status: fix complete in PR fix(home): run sync-models and proxy shims from checkout bin (#883) #4673 (commit 892f5a1, 8 sites migrated). NOT merged: basic: OpenCode metered-provider guard is cancelled and its workflow is disabled (gh run rerun → "Unable to retry disabled workflow"), so green is unreachable without operator action. Deploy/switch stays with the operator per packet.
  • Need: operator adjudication on the disabled guard + a switch window; then Home-layer eval uses a stale bin/ tree: commandcode-proxy unit 203/EXEC, managed opencode stuck on old rev #883 criteria 1–4 can close.

@dezren39

dezren39 commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · supplement — shim build verification (task 6513)

  • Agent: repo-worker-code (opencode lane, session ses_e5e5f822132ffegLLPlcfg2x6r)
  • Built all 7 migrated shims from the PR-branch eval (nixosConfigurations.amd): every wrapper execs $HOME/code/bin/<name>.mjs — zero store-baked bin/ snapshots remain in home.packages output.
  • Combined with the oneshot eval probe in the prior note, acceptance 2–3 hold at build level. Task parked: PR fix(home): run sync-models and proxy shims from checkout bin (#883) #4673 awaits operator adjudication on the disabled metered-provider guard + a switch window. No merge, no switch performed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home-layer eval uses a stale bin/ tree: commandcode-proxy unit 203/EXEC, managed opencode stuck on old rev

1 participant