Repository navigation
Conversation
…ck (#1411) Adds a fast-lane flake check that fails when any production .rs file under pkgs/id exceeds 2,500 production lines (lines before the first #[cfg(test)]). pkgs/id/src/web/markdown.rs is grandfathered at its current 5,312 lines with the split tracked in #1438 (allowance only shrinks); module-gated src/encryption/tests.rs is recorded test-only. The just recipe also runs the companion self-test, so CI proves the guard fails (new violator, grandfather growth, empty scan) as well as passes. Listed in .github/scripts/id-pr-checks.txt; just-recipes.json regenerated (also syncs the roc-test body drift left by #4626).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing as duplicate of PR #4709, the PR bound to the live queue task 6592 (protocol §8). The salvage comparison is posted on PR #4709: this PR's counter uses the superseded truncate-at-first-#[cfg(test)] method, and its one unique idea (shrink-only grandfather ceilings) is recorded on PR #4709 for a possible follow-up rather than salvaged. Thank-you to the originating session — the gap analysis matched; only the implementation is superseded. |
Queue task 6592 (repo-health-code-pilot) — scoped small_fix for #1411.
What
New fast-lane flake check
prod-lines-check(listed in.github/scripts/id-pr-checks.txt) that fails when any production.rsfile underpkgs/idexceeds 2,500 production lines (lines before the first#[cfg(test)], the #1078 audit method), naming the file and its count.pkgs/id/scripts/prod-lines-check.sh— the guard. Grandfatherssrc/web/markdown.rsat its current 5,312 production lines with the split tracked in id: F11.10 large-module split has no automated enforcement — add a production file-size check to the fast lane #1438 (allowance only shrinks; any growth fails). Recordssrc/encryption/tests.rsas test-only (module-gated via#[cfg(test)] mod tests); package-roottests/andvendor/are out of scope.pkgs/id/scripts/prod-lines-check-test.sh— companion self-test run by the same just recipe, so CI proves the guard fails (new over-limit file, grandfather growth, empty scan) as well as passes.pkgs/id/justfileprod-lines-checkrecipe +pkgs/id/flake.nixcheck entry.just-recipes.jsonregenerated (also syncs the staleroc-testbody left by fix(design-code): repoint :18745 legs to antigravity-direct :18751 (#1413, unblocks opencode#1409) #4626 — pre-existing drift, no behavior change).Verified (worktree at origin/main 0400795)
src/web/markdown.rsat 5,312 (grandfathered), 1 test-only skip.just prod-lines-check(guard + self-test) passes;shellcheck/ clean;check-id-pr-checks.shgreen (29 checks);nix evallists the new check.nix buildof the check derivation is running as local validation; theidmatrix + nightly full flake check cover it post-merge (repo runs that suite on push-to-main).Notes for neighboring work
markdown.rssplit packet): this guard is built to be reused — after the split lands, delete the grandfather entry and the plain 2,500 limit applies. No files touched here overlap the split itself.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.