Repository navigation
test(id): remove remaining polling sleeps from world tests (#1326) - #4700
Merged
Merged
Conversation
Convert the 9 remaining tokio::time::sleep waits in pkgs/id/src/world/tests.rs to deterministic await-point waits: yield_now inside the existing deadline-bounded caps_report/records condition loops, and a journaled-condition wait (host chat line committed) instead of the 100ms settle in the actor journaling test. No sleep remains in the file, so the F11.5 exit criterion is now literally met; the Phase 11 status record says so.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1326 (queue task 6564).
F11.5 is recorded Done, but its exit criterion ("no sleep in world.rs tests, and the schedule tests run in under one second") was not literally met:
pkgs/id/src/world/tests.rsstill contained 9tokio::time::sleepcalls.Change
tokio::task::yield_now()inside the existing deadline-bounded condition loops.No production code touched (clock, actor, scheduler behavior unchanged).
Verification
grep tokio::time::sleep pkgs/id/src/world/tests.rs→ 0 matches.cargo test -p id --lib world::→ 184 passed, 0 failed.cargo test -p id --lib world::tests::schedule_tests::→ 18 passed in 0.00–0.06 s (exit criterion: under one second).Closes #1326.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.