Skip to content

id: hosted account + ID binding ceremony (spec §§1,3) (#3808) - #4854

Merged
dezren39 merged 2 commits into
mainfrom
queue/5814-3808-hosted-binding-ceremony
Nov 3, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/5814-3808-hosted-binding-ceremony

Conversation

@dezren39

@dezren39 dezren39 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Implements slice 1 of the hosted provisioning + SSO→ID binding spec (#2258; tracker #2852), gated by the #2046 ruling (2026-11-03): CSE offered at binding, default ON; 30-day rebind wait (enforced in slice 2, #3809).

Scope: spec §§1,3 only — account registry keyed by Google sub, stable opaque binding_id, Iroh-root-signed challenge and service attestation, in-browser and own-node (pairing-code) variants, device linkage through existing groups grants.

Acceptance evidence:

  • 15 targeted unit tests in pkgs/id/src/hosted_binding.rs cover both ceremony variants plus wrong-key, replay, expiry, retry, uniqueness (sub + iroh_id), first-wins race, and tamper rejection; rebind-safe binding_id via JSON round-trip.
  • Full lib suite: 1927 passed, 0 failed (id) + 281 passed (id-core); --no-default-features failure is pre-existing on clean main (unrelated chat/invite gating).
  • No email-as-identity (email-shaped subs rejected, no email lookup); no custodial keys (service holds only its own attestation key).
  • CSE product default ON per the id: design: ID serverless edition v1 (Cloudflare Workers) #2046 ruling; the offer disclosure is in-code (CSE_OFFER_DISCLOSURE).

Dependency note: sha2 and base64 move from optional (world/web) to required deps — the ceremony needs SHA-256 attestation and base64 nonces in every build variant.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Implements slice 1 of the hosted provisioning + SSO→ID binding spec
(#2258; tracker #2852) under the #2046 ruling (CSE offered at binding,
default ON; 30-day rebind wait enforced in slice 2, #3809).

- Account registry keyed by Google sub; email is contact metadata only
  (email-shaped subs rejected; no email lookup).
- Stable opaque binding_id; Iroh-root-signed challenge + service
  attestation; full transcript persisted for offline verification.
- In-browser and own-node (pairing-code) variants; wrong-key, replay,
  expiry, retry, uniqueness, and race cases per §3.4.
- CSE choice recorded with default ON; devices attach via existing
  groups device grants, never touching the binding record.
- sha2/base64 now required deps (were optional world/web-only).
@dezren39
dezren39 requested a review from a team as a code owner November 3, 2026 10:18
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T10:18:35.876195Z
We couldn’t complete this review. Comment @codex review to try again.
7d71731 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2550e60c-390a-4f1c-9d80-11997d56414a
Commits

Reviewing files that changed from the base of the PR and between 8e76c6f and 5fccfd3.

Files selected for processing: 3
  • pkgs/id/Cargo.toml
  • pkgs/id/src/hosted_binding.rs
  • pkgs/id/src/lib.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant