Repository navigation
id: hosted account + ID binding ceremony (spec §§1,3) (#3808) - #4854
Conversation
Implements slice 1 of the hosted provisioning + SSO→ID binding spec (#2258; tracker #2852) under the #2046 ruling (CSE offered at binding, default ON; 30-day rebind wait enforced in slice 2, #3809). - Account registry keyed by Google sub; email is contact metadata only (email-shaped subs rejected; no email lookup). - Stable opaque binding_id; Iroh-root-signed challenge + service attestation; full transcript persisted for offline verification. - In-browser and own-node (pairing-code) variants; wrong-key, replay, expiry, retry, uniqueness, and race cases per §3.4. - CSE choice recorded with default ON; devices attach via existing groups device grants, never touching the binding record. - sha2/base64 now required deps (were optional world/web-only).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…14-3808-hosted-binding-ceremony
Implements slice 1 of the hosted provisioning + SSO→ID binding spec (#2258; tracker #2852), gated by the #2046 ruling (2026-11-03): CSE offered at binding, default ON; 30-day rebind wait (enforced in slice 2, #3809).
Scope: spec §§1,3 only — account registry keyed by Google
sub, stable opaquebinding_id, Iroh-root-signed challenge and service attestation, in-browser and own-node (pairing-code) variants, device linkage through existing groups grants.Acceptance evidence:
pkgs/id/src/hosted_binding.rscover both ceremony variants plus wrong-key, replay, expiry, retry, uniqueness (sub + iroh_id), first-wins race, and tamper rejection; rebind-safebinding_idvia JSON round-trip.--no-default-featuresfailure is pre-existing on clean main (unrelated chat/invite gating).CSE_OFFER_DISCLOSURE).Dependency note:
sha2andbase64move from optional (world/web) to required deps — the ceremony needs SHA-256 attestation and base64 nonces in every build variant.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.