Repository navigation
id: delayed ID-key rebind protocol — spec §4 (#3809) - #4885
Merged
Merged
Conversation
Fast path: old root key signs a rebind authorization over
{binding_id, new_iroh_id, challenge_id} from a fresh challenge and the
new key countersigns proof of possession — immediate on verification.
Delayed path: authenticated session + new-key challenge proof creates a
rebind request effective after the #2046-ruled 30-day wait; the binding
enters rebind_pending (re-attested) and keeps reserving the account, so
no fresh ceremony can bypass the wait. §4.3 notice artefact names the
new key fingerprint, effective_at, and the cancellation method; the old
key can cancel (id-rebind-cancel/v1 || rebind_id, final, a later request
restarts the full wait) or approve early, converting the request to the
fast path. At effect (§4.4) history is appended, the key is replaced,
the record is re-attested, and a rebind record signed by the service
and countersigned by the new key is published and retained; cancelled
and effected requests are kept as the auditable history.
Tests: 6 new deterministic tests cover the delayed request/notice and
pending bypass, cancel + full-wait restart, effect at effective_at with
offline-verifiable signed publication, the fast path and its forged-
authorization rejection, approve-early conversion, and expired-challenge
rejection. cargo test --lib hosted_binding: 21 passed on the laptop.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
|
🤖 Agent note · merge disposition (task 5815)
|
This was referenced Nov 3, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2258 spec §4 (delayed ID-key rebind) in
pkgs/id/src/hosted_binding.rs— slice 2 of #2852, gated by the #2046 ruling (30-day wait, CSE default ON landed in slice 1).What lands
rebind_with_old_key_authorization: old root key signs a rebind authorization over{binding_id, new_iroh_id, challenge_id}from a fresh §3 challenge; the new key proves possession via that challenge and countersigns the §4.4 record. Immediate on verification.request_delayed_rebind: authenticated session + fresh challenge proof of the new key creates a request witheffective_at = requested_at + 30 days(REBIND_WAITING_PERIOD_SECS, the id: design: ID serverless edition v1 (Cloudflare Workers) #2046 parameter — not chosen locally). The binding entersrebind_pending(service attestation regenerated); the old key keeps full control, and fresh ceremonies keep failing with the existing §3.4RebindPendingconflict for the whole wait — no bypass.RebindNoticenaming the new key fingerprint,effective_at, and the cancellation method.cancel_rebindverifies the old key's signature overid-rebind-cancel/v1 || rebind_id; cancellation is final and a later request restarts the full wait. Old-key approval converts a pending request to an immediate fast-path rebind.via=old-key-signature/delayed-rebind), the binding key is replaced and re-attested, indexes are updated, and aRebindRecord— service-signed over every field, countersigned by the new key over the transfer claim — is published and retained. Cancelled/effected requests are retained as the auditable history.verify_rebind_recordchecks a record offline against a pinned service key.RebindErrortaxonomy).Tests
cargo test --lib hosted_bindingon the laptop: 21 passed (15 pre-existing + 6 new deterministic tests): delayed request/notice + pending bypass + second-request refusal; cancel restoringactiveand restarting the full wait; effect ateffective_atwith signed publication verified offline and the old key freed; fast path + forged-authorization rejection; approve-early conversion; expired-challenge rejection.Refs #3809, #2852.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.