Repository navigation
Conversation
docs/dependencies.md claimed Nine direct Go modules and listed nine; pkgs/mcpx/go.mod has eleven direct requires. The two missing ones were github.com/mattn/go-runewidth (TUI cell widths: wide characters, combining marks and emoji) and golang.org/x/net (publicsuffix/idna at the elicitation answer review, #1678). pkgs/mcpx/package.nix made the same claim in the other direction ("Five direct Go dependencies") while the doc pointed readers at it for each trade. Both now say Eleven and carry the missing purposes, so the count and the list agree with go.mod. Verified: every direct require in go.mod appears in the doc table and nothing else does; the count sentence and the package.nix comment both read Eleven.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
What
pkgs/mcpx/docs/dependencies.mdsaid Nine direct Go modules and listed nine.pkgs/mcpx/go.modhas eleven direct requires. This PR makes the doc and the Nix comment agree with the code.Missing from both:
github.com/mattn/go-runewidth— cell width in the TUI (internal/tui/data.go): wide characters, combining marks and emoji take one or two cells, and truncation must agree with the terminal, notlen().golang.org/x/net—publicsuffix+idnain the elicitation answer review (internal/cli/elicit.go): registrable domain under a URL about to be answered, both host forms, punycode warning (mcpx: Phase 3 of #1675 — review-first mcpx elicit surface + nix#255 truth-up #1678).pkgs/mcpx/package.nixcarried the same drift the other way ("Five direct Go dependencies") while the doc pointed at it for the per-dependency trade. It now says Eleven too and carries the six purposes it was missing.Verification
Output:
11 direct modules; doc matches. The count sentence reads Eleven and thepackage.nixcomment reads Eleven.No test: doc-only change (two Markdown/Nix-comment rows); verification is the go.mod-vs-doc recount script above, and there is no behavior to regression-test.
Fixes #1883 (item 12 residue).
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.