Skip to content

fix(aggregator): validate provider usage generated_at - #5173

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/8819-5140-provider-usage-date
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/8819-5140-provider-usage-date

Conversation

@dezren39

@dezren39 dezren39 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Fixes #5140.

Summary

- if (!ts || Number.isNaN(Date.parse(ts))) return [];
+ if (!ts || parseIsoDate(ts) === null) return [];

Regression coverage in test/snapshot-writers.test.ts rejects impossible dates, non-ISO text, and garbage, while checking a valid control still produces records accepted by isSnapshotRecord.

Evidence

  • Before: bun test test/snapshot-writers.test.ts — 23 pass, 1 fail; 2026-02-30T10:59:33Z incorrectly produced three records.
  • After: bun test test/snapshot-writers.test.ts — 24 pass, 0 fail.
  • Full suite: bun test — 1432 pass, 0 fail.

Merge Danger

Door: two-way

Blast Radius: low — invalid provider-usage timestamps are rejected at derivation; valid timestamps and unrelated record paths are unchanged.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 3, 2026 21:51
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4994491f-1d56-4591-94ca-562c6edb1c87
Commits

Reviewing files that changed from the base of the PR and between afc3d80 and 4edece7.

Files selected for processing: 2
  • pm-stack/aggregator/src/snapshot-records.ts
  • pm-stack/aggregator/test/snapshot-writers.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T21:53:03.377524Z 4edece7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

Stale-PR warden: no activity for 3 days. Resolution task: #6911 — this PR should be merged, fixed, or closed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant